Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Env Load #2

Merged
merged 3 commits into from
Nov 5, 2018
Merged

Env Load #2

merged 3 commits into from
Nov 5, 2018

Conversation

markhuot
Copy link
Contributor

For your consideration: this does two things,

  1. removes the need to add all of the default cog-script to the path. Instead only cog is exposed and all the other defaults are called by their full path. This ensures cog doesn't pollute the global namespace.

  2. (more fun) whenever cog is run it will automatically source a .env file, if it exists. That means you can run something like cog solr and you don't have to include all the variables inside the file, it'll pick them up out of the .env file. My thought is that we can then move cog-ssh over to the default and just expose a variable for it.

@markhuot
Copy link
Contributor Author

markhuot commented May 9, 2018

@mrpaulphan, thoughts on this? I'd like to clean up our cog implementation so we're using it consistently across projects.

@mrpaulphan mrpaulphan merged commit 2de6620 into master Nov 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants