Enable 3D decoders in ld-analyse #516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atsampson
added
enhancement
ld-decode-tools
|
I committed the other pull request as is, but I think @simoninns should look at this one (time permitting) |
Previously filterIQ was being given the original YIQ data rather than the copy, which meant it had no effect on the output. Since fixing this results in lower-quality output (the demodulator works fine without a postfilter), disable it by default. The same applied to the call to denseOpticalFlow in the currently-disabled OpenCV code, which meant that motion detection was being done on the baseband NTSC signal rather than the luma as intended.
deemp.h provides constants for this (with the same value), so use them instead.
It's not needed -- in 3D mode, the baseband data doesn't get overwritten, so running splitIQ again is sufficient to rebuild the YIQ arrays. This saves copying quite a bit of data.
This is consistent with PalColour.
This is the same interface for 3D decoding as in PalColour, so the old decodeFrame interface that was only used by ld-analyse can go away, and ld-analyse can now support 3D decoding (although this isn't enabled yet).
The defaults remain as 2D for NTSC, because 3D isn't very useful at the moment, and Transform 2D for PAL, because 3D is rather slow.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is on top of the changes in #512, so don't merge until that one's been approved - it may need a rebase.The main thing here is reworking
Combso that it provides the samedecodeFramesinterface for 3D decoding asPalColour, then making ld-analyse use it. BecauseCombnow has access to the complete batch of fields being decoded it should make future NTSC 3D work a bit easier too.There are now radio buttons in the chroma decoder dialog that allow you to select 3D decoding for NTSC and PAL. I've left the defaults as 2D, because NTSC 3D isn't generally useful and Transform PAL 3D is a bit slow for interactive use.
This also includes a fix for the
Comb::filterIQproblem in #513, and adds a checkbox forcolorLpfso you can experiment with it.