Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is on top of the changes in #512, so don't merge until that one's been approved - it may need a rebase.The main thing here is reworking
Comb
so that it provides the samedecodeFrames
interface for 3D decoding asPalColour
, then making ld-analyse use it. BecauseComb
now has access to the complete batch of fields being decoded it should make future NTSC 3D work a bit easier too.There are now radio buttons in the chroma decoder dialog that allow you to select 3D decoding for NTSC and PAL. I've left the defaults as 2D, because NTSC 3D isn't generally useful and Transform PAL 3D is a bit slow for interactive use.
This also includes a fix for the
Comb::filterIQ
problem in #513, and adds a checkbox forcolorLpf
so you can experiment with it.