Fix off-by-one error when selecting replacement lines #631
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Gamnn spotted that a dropout on the last line of the active region wasn't being corrected.
This is because the ld-dropout-correct code largely works in terms of 1-based line numbering, but the replacement search code was bounded by
first/lastActiveFieldLine
which use 0-based numbering.This is the minimal fix - I think in the future it'd be better to rework ld-dropout-correct to use 0-based numbering internally. But the testcase in this bug is also a good example of why it'd be better to do a similarity comparison like ntsc3d does - it would be able to find an identical replacement for the line from a previous field...
Fixes #627.