Java 8 multiple lib upgrades #18
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -263,7 +263,7 @@ private JSLintResult lintFile(JSLint jsLint, File file) throws MojoExecutionExce | |||
| } catch (IOException e) { | |||
| throw new MojoExecutionException("problem whilst linting " + file, e); | |||
| } finally { | |||
| Closeables.closeQuietly(reader); | |||
There was a problem hiding this comment.
Why the switch to apache commons? I don't mind, I'm just curious.
There was a problem hiding this comment.
The guava version was removed: google/guava#1118
| @@ -1,7 +1,7 @@ | |||
| package com.googlecode.jslint4java.ant; | |||
|
|
|||
| import static org.hamcrest.CoreMatchers.*; | |||
| import static org.junit.Assert.*; | |||
| import static org.hamcrest.MatcherAssert.assertThat; | |||
There was a problem hiding this comment.
What's the difference between the hamcrest assertThat and the JUnit assertThat?
(apologies I've not been in the Java ecosystem for some time)
There was a problem hiding this comment.
The old one is deprecated
https://junit.org/junit4/javadoc/4.13/org/junit/Assert.html#assertThat(T,%20org.hamcrest.Matcher)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @happygiraffe ,
I've been able to upgrade to java 8 as well as upgrading multiple libraries.
There's more to do:
jcommanderfurtherjslint.js...but thought it would be good to get this in.
😀 🦒