Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(bank): custom burn coins logic + upgrade evmos v3 -> v4 #3

Merged
merged 3 commits into from
Jul 8, 2022
Merged

feat(bank): custom burn coins logic + upgrade evmos v3 -> v4 #3

merged 3 commits into from
Jul 8, 2022

Conversation

kioqq
Copy link
Member

@kioqq kioqq commented Jul 5, 2022 •
edited
Loading

Description

For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@kioqq kioqq changed the title feat(evmos): Bank.BurnCoins hook in Staking & Gov modules, distributi… feat(evmos): custom burn coins logic + upgrade v3 -> v4 Jul 5, 2022
@kioqq kioqq requested a review from onsails July 5, 2022 14:22
onsails
onsails requested changes Jul 5, 2022
View reviewed changes
Copy link
Member

@onsails onsails left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't review
Waiting for test covering all scenarios this burn->community pool redirect affects

@kioqq kioqq changed the title feat(evmos): custom burn coins logic + upgrade v3 -> v4 feat(bank): custom burn coins logic + upgrade v3 -> v4 Jul 6, 2022
@kioqq kioqq changed the title feat(bank): custom burn coins logic + upgrade v3 -> v4 feat(bank): custom burn coins logic + upgrade evmos v3 -> v4 Jul 6, 2022
@kioqq kioqq requested a review from onsails July 6, 2022 01:57
@kioqq kioqq force-pushed the burn branch 5 times, most recently from 9b5bf04 to 5e4fba3 Compare July 7, 2022 04:27
@onsails onsails mentioned this pull request Jul 7, 2022
Closed
onsails
onsails requested changes Jul 8, 2022
View reviewed changes
x/bank/haqq_burn_coins_test.go Outdated Show resolved Hide resolved
x/bank/haqq_burn_coins_test.go Outdated Show resolved Hide resolved
x/bank/haqq_burn_coins_test.go Outdated Show resolved Hide resolved
x/bank/haqq_burn_coins_test.go Outdated Show resolved Hide resolved
x/bank/haqq_burn_coins_test.go Outdated Show resolved Hide resolved
x/bank/haqq_burn_coins_test.go Outdated Show resolved Hide resolved
types/utils.go Outdated Show resolved Hide resolved
@onsails onsails merged commit e658fc6 into master Jul 8, 2022
@onsails onsails deleted the burn branch July 8, 2022 11:28
PastaHash added a commit to PastaHash/haqq-2 that referenced this pull request Jul 12, 2022
@PastaHash
Squashed commit of the following:
4fa912c 
commit c5ad59c22227d357c39da66d91ef38f3a97a5ff5
Merge: 0a8a8ef 85cb3b0
Author: Nikita Lukianchenko <pastahashff@gmail.com>
Date:   Tue Jul 12 10:08:17 2022 +0200

    fix(docs): testnet descriptions changed

commit 0a8a8ef4b50b9efbffb69a2e31e97b140a5b4cdd
Author: Nikita Lukianchenko <pastahashff@gmail.com>
Date:   Tue Jun 21 11:39:58 2022 +0200

    fix(docs): descriptions, metamask guide, links changed

commit 85cb3b0
Merge: 6fce768 5821536
Author: Nikita Lukianchenko <64983191+PastaHash@users.noreply.github.com>
Date:   Tue Jul 12 10:00:15 2022 +0200

    Merge branch 'master' into fix-docs

commit 6fce768
Author: Nikita Lukianchenko <pastahashff@gmail.com>
Date:   Tue Jul 12 09:59:38 2022 +0200

    fix(docs): descriptions, metamask guide, links changed

commit 5821536
Merge: a134b91 11c20aa
Author: Evgeniy Abramov <5331145+kioqq@users.noreply.github.com>
Date:   Mon Jul 11 20:23:59 2022 +0300

    Merge pull request haqq-network#9 from haqq-network/enbale_pos

    feat: enable PoS

commit 11c20aa
Author: Evgeniy Abramov <i@kio.ninja>
Date:   Mon Jul 11 19:28:45 2022 +0300

    feat: enable PoS

commit a134b91
Merge: e658fc6 c415d2e
Author: Evgeniy Abramov <5331145+kioqq@users.noreply.github.com>
Date:   Mon Jul 11 19:07:01 2022 +0300

    Merge pull request haqq-network#8 from haqq-network/fix_total_supply

    chore: better calc mint amount for fix total supply

commit c415d2e
Author: Evgeniy Abramov <i@kio.ninja>
Date:   Mon Jul 11 18:59:25 2022 +0300

    chore: better calc mint amount for fix total supply

commit e658fc6
Merge: d3c676e 2e5b58f
Author: Andrey Kuznetsov <fear@loathing.in>
Date:   Fri Jul 8 15:27:51 2022 +0400

    Merge pull request haqq-network#3 from haqq-network/burn

    feat(bank): custom burn coins logic + upgrade evmos v3 -> v4

commit 2e5b58f
Author: Evgeniy Abramov <i@kio.ninja>
Date:   Fri Jul 8 14:12:40 2022 +0300

    chore: strict check for chainid in utils

commit ddd6c3b
Author: Evgeniy Abramov <i@kio.ninja>
Date:   Thu Jul 7 20:12:00 2022 +0300

    fix: mint burned tokens to community pool

commit 5d58ed4
Author: Evgeniy Abramov <i@kio.ninja>
Date:   Thu Jul 7 07:38:21 2022 +0300

    feat(bank): custom burn coins logic + upgrade v3 -> v4
PastaHash added a commit to PastaHash/haqq-2 that referenced this pull request Jul 12, 2022
@PastaHash
Squashed commit of the following:
346f19f 
commit 4fa912c
Author: Nikita Lukianchenko <pastahashff@gmail.com>
Date:   Tue Jul 12 10:14:29 2022 +0200

    Squashed commit of the following:

    commit c5ad59c22227d357c39da66d91ef38f3a97a5ff5
    Merge: 0a8a8ef 85cb3b0
    Author: Nikita Lukianchenko <pastahashff@gmail.com>
    Date:   Tue Jul 12 10:08:17 2022 +0200

        fix(docs): testnet descriptions changed

    commit 0a8a8ef4b50b9efbffb69a2e31e97b140a5b4cdd
    Author: Nikita Lukianchenko <pastahashff@gmail.com>
    Date:   Tue Jun 21 11:39:58 2022 +0200

        fix(docs): descriptions, metamask guide, links changed

    commit 85cb3b0
    Merge: 6fce768 5821536
    Author: Nikita Lukianchenko <64983191+PastaHash@users.noreply.github.com>
    Date:   Tue Jul 12 10:00:15 2022 +0200

        Merge branch 'master' into fix-docs

    commit 6fce768
    Author: Nikita Lukianchenko <pastahashff@gmail.com>
    Date:   Tue Jul 12 09:59:38 2022 +0200

        fix(docs): descriptions, metamask guide, links changed

    commit 5821536
    Merge: a134b91 11c20aa
    Author: Evgeniy Abramov <5331145+kioqq@users.noreply.github.com>
    Date:   Mon Jul 11 20:23:59 2022 +0300

        Merge pull request haqq-network#9 from haqq-network/enbale_pos

        feat: enable PoS

    commit 11c20aa
    Author: Evgeniy Abramov <i@kio.ninja>
    Date:   Mon Jul 11 19:28:45 2022 +0300

        feat: enable PoS

    commit a134b91
    Merge: e658fc6 c415d2e
    Author: Evgeniy Abramov <5331145+kioqq@users.noreply.github.com>
    Date:   Mon Jul 11 19:07:01 2022 +0300

        Merge pull request haqq-network#8 from haqq-network/fix_total_supply

        chore: better calc mint amount for fix total supply

    commit c415d2e
    Author: Evgeniy Abramov <i@kio.ninja>
    Date:   Mon Jul 11 18:59:25 2022 +0300

        chore: better calc mint amount for fix total supply

    commit e658fc6
    Merge: d3c676e 2e5b58f
    Author: Andrey Kuznetsov <fear@loathing.in>
    Date:   Fri Jul 8 15:27:51 2022 +0400

        Merge pull request haqq-network#3 from haqq-network/burn

        feat(bank): custom burn coins logic + upgrade evmos v3 -> v4

    commit 2e5b58f
    Author: Evgeniy Abramov <i@kio.ninja>
    Date:   Fri Jul 8 14:12:40 2022 +0300

        chore: strict check for chainid in utils

    commit ddd6c3b
    Author: Evgeniy Abramov <i@kio.ninja>
    Date:   Thu Jul 7 20:12:00 2022 +0300

        fix: mint burned tokens to community pool

    commit 5d58ed4
    Author: Evgeniy Abramov <i@kio.ninja>
    Date:   Thu Jul 7 07:38:21 2022 +0300

        feat(bank): custom burn coins logic + upgrade v3 -> v4

commit 709eb9f
Merge: 2b8513d d3c676e
Author: Nikita Lukianchenko <pastahashff@gmail.com>
Date:   Wed Jul 6 12:12:50 2022 +0200

    Merge remote-tracking branch 'upstream/master' into dev

commit 2b8513d
Merge: d6569b0 c5ce84e
Author: Nikita Lukianchenko <pastahashff@gmail.com>
Date:   Tue Jun 28 12:23:54 2022 +0200

    Merge branch 'master' of https://github.com/PastaHash/haqq-2

commit d6569b0
Author: Nikita Lukianchenko <pastahashff@gmail.com>
Date:   Tue Jun 21 11:39:58 2022 +0200

    fix(docs): descriptions, metamask guide, links changed

commit c5ce84e
Author: Nikita Lukianchenko <pastahashff@gmail.com>
Date:   Mon Jun 27 16:42:33 2022 +0200

    labeler.yml upd

commit 391318e
Author: Nikita Lukianchenko <pastahashff@gmail.com>
Date:   Mon Jun 27 16:02:20 2022 +0200

    Update lint.yml

commit 6df0ad6
Author: Nikita Lukianchenko <pastahashff@gmail.com>
Date:   Mon Jun 27 15:59:52 2022 +0200

    labeler.yml permission changed

commit 574a000
Author: Nikita Lukianchenko <pastahashff@gmail.com>
Date:   Mon Jun 27 15:42:07 2022 +0200

    Update labeler.yml

commit 8681dc2
Author: Nikita Lukianchenko <pastahashff@gmail.com>
Date:   Mon Jun 27 14:04:43 2022 +0200

    Update labeler.yml

    labeler v3 -> v4

commit acd6123
Merge: 2756246 9a2ae6e
Author: Nikita Lukianchenko <pastahashff@gmail.com>
Date:   Mon Jun 27 13:47:38 2022 +0200

    Merge branch 'master' of https://github.com/PastaHash/haqq-2

commit 2756246
Author: Nikita Lukianchenko <pastahashff@gmail.com>
Date:   Mon Jun 27 13:47:35 2022 +0200

    Update labeler.yml

commit 9a2ae6e
Merge: 0012555 629e1d3
Author: Nikita Lukianchenko <64983191+PastaHash@users.noreply.github.com>
Date:   Mon Jun 27 11:39:52 2022 +0200

    Merge branch 'haqq-network:master' into master

commit 0012555
Author: Nikita Lukianchenko <pastahashff@gmail.com>
Date:   Mon Jun 27 11:37:17 2022 +0200

    fix(docs): testedge explorer url added, security.md upd

commit f273cba
Author: Nikita Lukianchenko <pastahashff@gmail.com>
Date:   Tue Jun 21 11:39:58 2022 +0200

    fix(docs): descriptions, metamask guide, links changed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@onsails onsails onsails approved these changes

Assignees
No one assigned
Labels
C:Types Type: Build
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kioqq @onsails