Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mengubah ArrayDictionary #15

Merged
merged 1 commit into from
Sep 23, 2018
Merged

Mengubah ArrayDictionary #15

merged 1 commit into from
Sep 23, 2018

Conversation

sanspa
Copy link
Contributor

@sanspa sanspa commented Sep 22, 2018

Mengubah dictionary dari list ke dictionary

Mengubah dictionary dari list ke dictionary
@ceefour
Copy link

ceefour commented Sep 22, 2018

👍 Fixes #7

@sanspa
Copy link
Contributor Author

sanspa commented Sep 22, 2018

penggunaan dictionary sebagai pengganti list
Semua method tidak berubah, sehingga bisa langsung digunakan tanpa merubah file lain.
Dengan penggunaan dictionary, maka kecepatan stemmer bisa digunakan untuk ribuan kalimat dalam beberapa menit saja

@har07
Copy link
Owner

har07 commented Sep 23, 2018

Travis-ci failed karena ada empty line di dalam file kata-dasar.txt yg menyebabkan tidak lolos sebuah test case ('di' menjadi '' setelah proses stemming, seharusnya tetap 'di'). Saya belum cek lebih dalam, tetapi sebelum menggunakan dictionary empty line tsb tidak menyebabkan test case di atas menjadi failed.

Anyways, empty line sudah saya hapus dari file kata-dasar.txt di branch master karena memang tidak diperlukan. Pull request ini seharusnya sudah aman dan lolos test.

@har07 har07 merged commit b31d6f6 into har07:master Sep 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants