Make rcpt_to.ldap work with aliases plugin #1501
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The aliases plugin modifies the transaction.rcpt_to array. Look at the latest entry added to the rcpt_to array and use that for looking up the destination LDAP account.
|
That last check appears to have failed due to something un-related to my PR. Can someone check and let me know if I need to do anything? |
Current coverage is 36.14%
@@ master #1501 diff @@
==========================================
Files 26 26
Lines 6442 6457 +15
Methods 838 839 +1
Messages 0 0
Branches 1691 1691
==========================================
Hits 2334 2334
- Misses 4108 4123 +15
Partials 0 0
|
|
It's that damn host check timeout. The other Matt thinks there is likely a bug there so I haven't dived into it yet.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request: