Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

normalized connection properties #1577

Merged
merged 2 commits into from
Oct 3, 2016
Merged

normalized connection properties #1577

merged 2 commits into from
Oct 3, 2016

Conversation

msimerson
Copy link
Member

this is a prequel to #1547

It includes just the changes in connection.js, as shrewdly suggested by @smfreegard, as well as using .set() more often as commented by @baudehlo.

  • converts connection.remote_* to connection.remote.*
  • converts connection.local_* to connection.local.*
  • converts connection.using_tls -> connection.tls.enabled
  • maintains previous names, providing backwards compatibility

@codecov-io
Copy link

Current coverage is 35.86% (diff: 25.71%)

Merging #1577 into master will increase coverage by 0.02%

@@             master      #1577   diff @@
==========================================
  Files            26         26          
  Lines          6541       6544     +3   
  Methods         849        850     +1   
  Messages          0          0          
  Branches       1706       1709     +3   
==========================================
+ Hits           2344       2347     +3   
  Misses         4197       4197          
  Partials          0          0          

Powered by Codecov. Last update ee66a96...c3ea781

@msimerson msimerson merged commit 8e412b1 into haraka:master Oct 3, 2016
@msimerson msimerson deleted the normalized-connection-properties branch October 3, 2016 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants