normalized connection properties #1577

Merged
merged 2 commits into from Oct 3, 2016

Conversation

Projects
None yet
2 participants
@msimerson
Member

msimerson commented Sep 3, 2016

this is a prequel to #1547

It includes just the changes in connection.js, as shrewdly suggested by @smfreegard, as well as using .set() more often as commented by @baudehlo.

  • converts connection.remote_* to connection.remote.*
  • converts connection.local_* to connection.local.*
  • converts connection.using_tls -> connection.tls.enabled
  • maintains previous names, providing backwards compatibility

@msimerson msimerson referenced this pull request Sep 3, 2016

Merged

normalized connection properties #1547

2 of 2 tasks complete
@codecov-io

This comment has been minimized.

Show comment
Hide comment
@codecov-io

codecov-io Oct 3, 2016

Current coverage is 35.86% (diff: 25.71%)

Merging #1577 into master will increase coverage by 0.02%

@@             master      #1577   diff @@
==========================================
  Files            26         26          
  Lines          6541       6544     +3   
  Methods         849        850     +1   
  Messages          0          0          
  Branches       1706       1709     +3   
==========================================
+ Hits           2344       2347     +3   
  Misses         4197       4197          
  Partials          0          0          

Powered by Codecov. Last update ee66a96...c3ea781

Current coverage is 35.86% (diff: 25.71%)

Merging #1577 into master will increase coverage by 0.02%

@@             master      #1577   diff @@
==========================================
  Files            26         26          
  Lines          6541       6544     +3   
  Methods         849        850     +1   
  Messages          0          0          
  Branches       1706       1709     +3   
==========================================
+ Hits           2344       2347     +3   
  Misses         4197       4197          
  Partials          0          0          

Powered by Codecov. Last update ee66a96...c3ea781

@msimerson msimerson merged commit 8e412b1 into haraka:master Oct 3, 2016

2 of 3 checks passed

codecov/patch 25.71% of diff hit (target 35.83%)
Details
codecov/project 35.86% (+0.02%) compared to ee66a96
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@msimerson msimerson deleted the msimerson:normalized-connection-properties branch Oct 3, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment