Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upnormalized connection properties #1577
Conversation
msimerson
added
the
Wants Review
label
Sep 3, 2016
msimerson
added some commits
Sep 3, 2016
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment
Hide comment
codecov-io
Oct 3, 2016
Current coverage is 35.86% (diff: 25.71%)
@@ master #1577 diff @@
==========================================
Files 26 26
Lines 6541 6544 +3
Methods 849 850 +1
Messages 0 0
Branches 1706 1709 +3
==========================================
+ Hits 2344 2347 +3
Misses 4197 4197
Partials 0 0 Powered by Codecov. Last update ee66a96...c3ea781
codecov-io
commented
Oct 3, 2016
Current coverage is 35.86% (diff: 25.71%)@@ master #1577 diff @@
==========================================
Files 26 26
Lines 6541 6544 +3
Methods 849 850 +1
Messages 0 0
Branches 1706 1709 +3
==========================================
+ Hits 2344 2347 +3
Misses 4197 4197
Partials 0 0
|
msimerson
merged commit 8e412b1
into
haraka:master
Oct 3, 2016
msimerson
deleted the
msimerson:normalized-connection-properties
branch
Oct 3, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
msimerson commentedSep 3, 2016
this is a prequel to #1547
It includes just the changes in connection.js, as shrewdly suggested by @smfreegard, as well as using .set() more often as commented by @baudehlo.