Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

partly remove haraka/plugins/dir support #1668

Merged
merged 4 commits into from
Oct 19, 2016
Merged

partly remove haraka/plugins/dir support #1668

merged 4 commits into from
Oct 19, 2016

Conversation

msimerson
Copy link
Member

@msimerson msimerson commented Oct 16, 2016

Fixes #1649

Changes proposed in this pull request:

  • remove support for $harakaDir/plugins/$name/ folders
  • while preserving it for $harakaLocalDir
  • if config/plugins name has a haraka-plugin- prefix, remove it (backwards compat)
  • updates Plugins.md accordingly

Checklist:

  • docs updated
  • tests updated

@msimerson msimerson changed the title make the change partly remove haraka/plugins/dir support Oct 16, 2016
@msimerson
Copy link
Member Author

Okay @baudehlo , I believe I have completed this per our conversation in #1649. Please review at your leisure.

@codecov-io
Copy link

codecov-io commented Oct 18, 2016

Current coverage is 35.93% (diff: 100%)

Merging #1668 into master will increase coverage by 0.04%

@@             master      #1668   diff @@
==========================================
  Files            24         24          
  Lines          6068       6072     +4   
  Methods         782        782          
  Messages          0          0          
  Branches       1535       1536     +1   
==========================================
+ Hits           2178       2182     +4   
  Misses         3890       3890          
  Partials          0          0          

Powered by Codecov. Last update b27008f...643a824

@msimerson msimerson merged commit e00a002 into haraka:master Oct 19, 2016
@msimerson msimerson deleted the 1649-plugin-dir-support branch October 19, 2016 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

replace plugin/$name with node_modules/haraka-plugin-$name
3 participants