partly remove haraka/plugins/dir support #1668

Merged
merged 4 commits into from Oct 19, 2016

Conversation

Projects
None yet
3 participants
@msimerson
Member

msimerson commented Oct 16, 2016

Fixes #1649

Changes proposed in this pull request:

  • remove support for $harakaDir/plugins/$name/ folders
  • while preserving it for $harakaLocalDir
  • if config/plugins name has a haraka-plugin- prefix, remove it (backwards compat)
  • updates Plugins.md accordingly

Checklist:

  • docs updated
  • tests updated

@msimerson msimerson changed the title from make the change to partly remove haraka/plugins/dir support Oct 16, 2016

@msimerson

This comment has been minimized.

Show comment
Hide comment
@msimerson

msimerson Oct 16, 2016

Member

Okay @baudehlo , I believe I have completed this per our conversation in #1649. Please review at your leisure.

Member

msimerson commented Oct 16, 2016

Okay @baudehlo , I believe I have completed this per our conversation in #1649. Please review at your leisure.

msimerson added some commits Oct 16, 2016

* remove haraka/plugins/dir support
* strip haraka-plugin- prefix from plugin names (if present)
@codecov-io

This comment has been minimized.

Show comment
Hide comment
@codecov-io

codecov-io Oct 18, 2016

Current coverage is 35.93% (diff: 100%)

Merging #1668 into master will increase coverage by 0.04%

@@             master      #1668   diff @@
==========================================
  Files            24         24          
  Lines          6068       6072     +4   
  Methods         782        782          
  Messages          0          0          
  Branches       1535       1536     +1   
==========================================
+ Hits           2178       2182     +4   
  Misses         3890       3890          
  Partials          0          0          

Powered by Codecov. Last update b27008f...643a824

codecov-io commented Oct 18, 2016

Current coverage is 35.93% (diff: 100%)

Merging #1668 into master will increase coverage by 0.04%

@@             master      #1668   diff @@
==========================================
  Files            24         24          
  Lines          6068       6072     +4   
  Methods         782        782          
  Messages          0          0          
  Branches       1535       1536     +1   
==========================================
+ Hits           2178       2182     +4   
  Misses         3890       3890          
  Partials          0          0          

Powered by Codecov. Last update b27008f...643a824

@msimerson msimerson merged commit e00a002 into haraka:master Oct 19, 2016

3 checks passed

codecov/patch 100% of diff hit (target 35.89%)
Details
codecov/project 35.93% (+0.04%) compared to b27008f
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@msimerson msimerson deleted the msimerson:1649-plugin-dir-support branch Oct 19, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment