Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mf.resolvable: reduce timeout by one second (so < plugin.timeout) #2544

Merged
merged 3 commits into from
Nov 26, 2018

Conversation

msimerson
Copy link
Member

fixes #2448

Changes proposed in this pull request:

  • reduce default timeout by one second (so < plugin.timeout)
  • reduce timeout if its >= plugin.timeout

@codecov
Copy link

codecov bot commented Nov 21, 2018

Codecov Report

Merging #2544 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2544   +/-   ##
=======================================
  Coverage   59.45%   59.45%           
=======================================
  Files          28       28           
  Lines        6200     6200           
  Branches     1543     1543           
=======================================
  Hits         3686     3686           
  Misses       2514     2514

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dbc888e...b7548f4. Read the comment docs.

@msimerson msimerson changed the title reduce timeout by one second (so < plugin.timeout) mf.resolvable: reduce timeout by one second (so < plugin.timeout) Nov 21, 2018
@msimerson msimerson merged commit 696c86e into haraka:master Nov 26, 2018
@msimerson msimerson deleted the 2448-reduce-is_resolvable-timeout branch November 26, 2018 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Plugin mail_from.is_resolvable timed out on hook mail - make sure it calls the callback
1 participant