Two channel board tensor #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
there is also the possibility of introducing a |
|
I wouldn't introduce a legacy board tensor but rather have board provide a function get_owner(position) which knows about the roatation logic. |
|
I think that anything that doesn't need backpropagation / gpu support should use easy to use board functions instead of board_tensor |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I changed the board tensor to two channels. The channels exchanged (
torch.roll) and transposed after every move. I tried converting three layer models to two layer models but the output required retraining so I suggest just training new models (which appears to be faster). Please take a look at the branch and notify me whether it works for you.