Enable support for non default config section

[pierreluctg]

This change allow to use other config sections.

can.ini

[default]
interface = neovi
channel = 1

[HS1]
interface = neovi
channel = 1
serial = 456

[HS2]
channel = 2
serial = 123

>>> hs1_bus = can.interface.Bus(config_section='HS1')
>>> hs1_bus.__class__.__name__
'NeoViBus'

>>> hs2_bus = can.interface.Bus(config_section='HS2')
>>> hs2_bus.__class__.__name__
'NeoViBus'

[felixdivo]

The looks like a good idea. But I think the docs should make clear that the default section is always loaded, and the other given section only updates the config from the default section. This feature in general should probably also be mentioned in doc/configuration.rst.

[pierreluctg]

Documentation have been updated.

[pierreluctg]

@felixdivo and @hardbyte do you think that config_section is a good name or should is be something more generic like bus_name?

[felixdivo]

The "(None)" is not required any more.

[felixdivo]

The only thing missing now are tests. I think load_config() is not tested anywhere in isolation as of now.

[pierreluctg]

@felixdivo, I will add few tests.

[pierreluctg]

@felixdivo, I have added tests to cover this newly added feature. This should be enough for this pull request. However, we should probably add more tests for load_config() in the future.

[felixdivo]

Yes, you are right. See #345. Thanks for the tests for this new feature.

[felixdivo]

I would merge this if the tests ran.

@hardbyte Do you think this is a good addition to the library?

[pierreluctg]

I will fix the code and test soon.

[codecov]

Codecov Report

Merging #338 into develop will increase coverage by 0.07%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           develop    #338      +/-   ##
==========================================
+ Coverage    58.52%   58.6%   +0.07%     
==========================================
  Files           54      54              
  Lines         4207    4215       +8     
==========================================
+ Hits          2462    2470       +8     
  Misses        1745    1745

Impacted Files	Coverage Δ
can/util.py	72.63% <100%> (+3.4%)	⬆️
can/interface.py	88.4% <100%> (-2.37%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 63d57e2...d6c6ada. Read the comment docs.

[pierreluctg]

can.util.load_file_config unit tests are all good now :)

[hardbyte]

Hey @pierreluctg this looks like a great addition. Personally I'd name it straight config or perhaps context instead of config_section - the section seems more like an internal detail where the user really just wants to say "use the configuration HS1 or HS2".

[felixdivo]

Merging #338 into develop will increase coverage by 0.06%.
The diff coverage is 100%.

👍 😄

[pierreluctg]

@hardbyte I do agree that config_section was not the best name.

I have renamed config_section to context and made it mode generic and usable by other config_sources if needed in the the future.