virtual_can_demo.py changes #373
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #373 +/- ##
===========================================
- Coverage 58.85% 57.08% -1.77%
===========================================
Files 54 57 +3
Lines 4214 4348 +134
===========================================
+ Hits 2480 2482 +2
- Misses 1734 1866 +132
Continue to review full report at Codecov.
|
examples/virtual_can_demo.py
Outdated
|
|
||
| # TODO Issue #3: Need to keep running to ensure the writing threads stay alive. ? | ||
| time.sleep(2) | ||
| with can.ThreadSafeBus(bustype='socketcan', channel='vcan0') as bus: |
There was a problem hiding this comment.
I think I'm missing something @felixdivo - what are you trying to protect by introducing the thread safe bus here?
As I understand it each executor function call (several will be running concurrently in separate processes) is creating its own can.ThreadSafeBus. If there are no threads sharing one ThreadSafeBus is there any point using it?
There was a problem hiding this comment.
You are right, I was apparently confused.
felixdivo
changed the title
No description provided.