Clean up bits generator TODO in PCAN interface #588
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the TODO to document how the bits generator works in the PCAN interface by adding documentation and renaming the variables to make things more clear.
karlding
force-pushed
the
remove_todo_in_pcan_interface
branch
from
a72eeaa
to
04d1a0e
Compare
Codecov Report
@@ Coverage Diff @@
## develop #588 +/- ##
===========================================
- Coverage 63.88% 61.54% -2.35%
===========================================
Files 63 63
Lines 5721 5713 -8
===========================================
- Hits 3655 3516 -139
- Misses 2066 2197 +131 |
Codecov Report
@@ Coverage Diff @@
## develop #588 +/- ##
===========================================
- Coverage 63.88% 63.87% -0.02%
===========================================
Files 63 63
Lines 5721 5722 +1
===========================================
Hits 3655 3655
- Misses 2066 2067 +1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the TODO to document how the bits generator works in the PCAN
interface by adding documentation and renaming the variables to make
things more clear.