Fix RecursionError in Message.__getattr__ #885
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
__getattr__ incorrectly assumes that self._dict always exists. However, if self._dict doesn't exist, the function attempts to call __getattr__ again, which results in infinite recursion when serializing the object via pickle. This fixes the implementation of __getattr__ and adds a test to exercise pickling/unpickling the Message. Fixes hardbyte#804
|
I saw that there was a I'll cherry pick the test over to |
hardbyte
approved these changes
Aug 5, 2020
|
Regarding making this change in develop - there is a code comment saying this whole method can be removed in 4.0? Do you mind checking if that is the case and either patching/removing cheers |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
getattr incorrectly assumes that self._dict always exists. However,
if self._dict doesn't exist, the function attempts to call getattr
again, which results in infinite recursion when serializing the object
via pickle.
This fixes the implementation of getattr and adds a test to exercise
pickling/unpickling the Message.
Fixes #804