Rename puppeteer util

hardkoded · Apr 15, 2023 · 347a69f · 347a69f
1 parent 4846607
commit 347a69f
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 6 deletions.
diff --git a/lib/PuppeteerSharp.Tests/EvaluationTests/PageEvaluateTests.cs b/lib/PuppeteerSharp.Tests/EvaluationTests/PageEvaluateTests.cs
@@ -279,7 +279,7 @@ public async Task ShouldThrowIfUnderlyingElementWasDisposed()
             var element = await Page.QuerySelectorAsync("section");
             Assert.NotNull(element);
             await element.DisposeAsync();
-            var exception = await Assert.ThrowsAsync<EvaluationFailedException>(()
+            var exception = await Assert.ThrowsAnyAsync<PuppeteerException>(()
                 => Page.EvaluateFunctionAsync<string>("e => e.textContent", element));
             Assert.Contains("JSHandle is disposed", exception.Message);
         }

diff --git a/lib/PuppeteerSharp.Tests/InjectedTests/InjectedTests.cs b/lib/PuppeteerSharp.Tests/InjectedTests/InjectedTests.cs
@@ -24,7 +24,7 @@ public async Task ShouldWork()
                       PuppeteerUtil => {
                         return typeof PuppeteerUtil === 'object';
                       }",
-                      await world.PuppeteerUtil);
+                      await world.GetPuppeteerUtilAsync());
             Assert.True(result);
         }
 
@@ -37,7 +37,7 @@ public async Task CreateFunctionShouldWork()
                 .PuppeteerWorld.EvaluateFunctionAsync<int>(@"({createFunction}, fnString) => {
                     return createFunction(fnString)(4);
                 }",
-                await world.PuppeteerUtil,
+                await world.GetPuppeteerUtilAsync(),
                 "() => 4");
             Assert.Equal(4, result);
         }

diff --git a/lib/PuppeteerSharp/Frame.cs b/lib/PuppeteerSharp/Frame.cs
@@ -235,7 +235,7 @@ public async Task<IElementHandle> AddStyleTagAsync(AddTagOptions options)
                   await promise;
                   return element;
                 }",
-                await PuppeteerWorld.PuppeteerUtil.ConfigureAwait(false),
+                await PuppeteerWorld.GetPuppeteerUtilAsync().ConfigureAwait(false),
                 options.Url,
                 options.Id,
                 options.Type,
@@ -300,7 +300,7 @@ public async Task<IElementHandle> AddScriptTagAsync(AddTagOptions options)
                   await promise;
                   return script;
                 }",
-                await PuppeteerWorld.PuppeteerUtil.ConfigureAwait(false),
+                await PuppeteerWorld.GetPuppeteerUtilAsync().ConfigureAwait(false),
                 options.Url,
                 options.Id,
                 options.Type,

diff --git a/lib/PuppeteerSharp/IsolatedWorld.cs b/lib/PuppeteerSharp/IsolatedWorld.cs
@@ -67,7 +67,7 @@ public IsolatedWorld(
 
         internal TaskCompletionSource<IJSHandle> PuppeteerUtilTaskCompletionSource { get; private set; } = new(TaskCreationOptions.RunContinuationsAsynchronously);
 
-        internal Task<IJSHandle> PuppeteerUtil => PuppeteerUtilTaskCompletionSource.Task;
+        internal Task<IJSHandle> GetPuppeteerUtilAsync() => PuppeteerUtilTaskCompletionSource.Task;
 
         internal async Task AddBindingToContextAsync(ExecutionContext context, string name)
         {