Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Query regarding ptc-go src #27

Closed
guitarpicva opened this issue Mar 13, 2020 · 4 comments
Closed

Query regarding ptc-go src #27

guitarpicva opened this issue Mar 13, 2020 · 4 comments
Assignees

Comments

@guitarpicva
Copy link

guitarpicva commented Mar 13, 2020

Hello again harenber,

Thanks again for producing this module for pat. It has released Winlink and my PTC modem from the jaws of Windows. It is greatly appreciated.

I was wondering if you would mind if I picked through your code in an attempt to do something similar for the Node Red platform, as well as to create direct "terminal" access to the PTC modems. One thing sorely lacking in Pactor-land is a nice ad hoc chat and infrastructure-less message transfer program combined into one UI. I have a great deal of experience along those lines and I think it is a natural fit for this ARQ modem.

Go is pretty similar to most languages I use so I am sure I can figure out the syntax in short order. The ancient and mostly un-needed serial protocol is the most annoying part, and I want to encapsulate that and surround it with a more modern TCP socket approach with an ASCII command set. This allows it to be sort of an appliance that can be used by various programs in a much simpler manner.

I know it is open source, but I thought it at least polite to ask your permission. :)

Regards,
Mitch
AB4MW

@harenber
Copy link
Owner

Hi Mitch,

the current version of the code is contributed by @blockmurder . Maybe he can/should comment.

What I am concernd, I am a friend of open-source, so I would be happy if any code would be re-used elsewhere.

BTW: I use node red myself for my complete home automation ( https://hub.docker.com/r/harenber/rpinodered-gruenbeck ).

73s

Torsten DL1THM

@guitarpicva
Copy link
Author

Torsten,

I will await input from @blockmurder as well then. Thank you.

Node Red is an obvious choice for this sort of serially controlled device. It also lends itself well to being able to have control of the device remotely from inaccessible sites, or on non-Amateur radio systems which is my primary target. I have built controllers for other commercially available modem devices in Node Red already.

Regards,
Mitch

@blockmurder
Copy link
Collaborator

@guitarpicva Sorry for the delayed response.
As mentioned in #28 @harenber will probably soon add a LICENCE file stating this software is licenced under MIT Licence

I like the idea of open-source so I'd love to see this code or parts of it being used in other open-source projects :-D

Cheers
Matthias

harenber added a commit that referenced this issue May 30, 2020
This is a new release that brings:

- support for PACTOR-4 Dragon modems #3
- support for CRC Hostmode instead of plain WA8DED hostmode
- adds a license #28, #27
- follows LA5NTA to move to Go modules la5nta/pat#199

most changes are done in modem.go, most notably:

- the underlying serial library has changed
- a lot of helper functions were added to support the CRC Hostmode
- handling of interrupted system calls on the serial line
- small bug fixes, especially #29
@harenber
Copy link
Owner

License added, so I think we can close this one here.

harenber added a commit that referenced this issue May 30, 2020
This is a new release that brings:

- support for PACTOR-4 Dragon modems
#3
- support for CRC Hostmode instead of plain WA8DED hostmode
- adds a license #28,
#27
- follows LA5NTA to move to Go modules
la5nta/pat#199

most changes are done in modem.go, most notably:

- the underlying serial library has changed
- a lot of helper functions were added to support the CRC Hostmode
- handling of interrupted system calls on the serial line
- small bug fixes, especially
#29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants