Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

running tests on pypy3 fails #74

Closed
anthrotype opened this issue Feb 17, 2021 · 1 comment · Fixed by #97
Closed

running tests on pypy3 fails #74

anthrotype opened this issue Feb 17, 2021 · 1 comment · Fixed by #97

Comments

@anthrotype
Copy link
Member

I noticed this while setting up Github Actions #73, since cibuildwheel attempts to build a wheel for pypy by default.
These are the failues:
https://github.com/harfbuzz/uharfbuzz/runs/1919782201?check_suite_focus=true#step:6:1008
https://ci.appveyor.com/project/fonttools/uharfbuzz/builds/37821221
@khaledhosny
Copy link
Collaborator

Looks like a bug in handling non-ASCII characters. Something is not working right in Buffer.add_str(). Probably https://foss.heptapod.net/pypy/pypy/-/issues/3413.

khaledhosny added a commit that referenced this issue Jul 25, 2021
@khaledhosny
Revert "ci.yml: skip building wheel on pypy3"
ef91ab1 
This reverts commit 4872a53.

It was probably broken by the following pypy bug and it is now fixed:
https://foss.heptapod.net/pypy/pypy/-/issues/3413

Fixes #74
@khaledhosny khaledhosny linked a pull request Jul 25, 2021 that will close this issue
Revert "ci.yml: skip building wheel on pypy3" #97
Merged
khaledhosny added a commit that referenced this issue Jul 26, 2021
@khaledhosny
Revert "ci.yml: skip building wheel on pypy3"
32faf7d 
This reverts commit 4872a53.

It was probably broken by the following pypy bug and it is now fixed:
https://foss.heptapod.net/pypy/pypy/-/issues/3413

Fixes #74
khaledhosny added a commit that referenced this issue Jul 28, 2021
@khaledhosny
Revert "ci.yml: skip building wheel on pypy3"
c311c29 
This reverts commit 4872a53.

It was probably broken by the following pypy bug and it is now fixed:
https://foss.heptapod.net/pypy/pypy/-/issues/3413

Fixes #74
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Revert "ci.yml: skip building wheel on pypy3" harfbuzz/uharfbuzz
2 participants
@khaledhosny @anthrotype