Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lmplements the inter-process readers writer lock #50

Merged
merged 2 commits into from
Nov 9, 2020
Merged

lmplements the inter-process readers writer lock #50

merged 2 commits into from
Nov 9, 2020

Conversation

psarka
Copy link
Collaborator

@psarka psarka commented Aug 11, 2020

This PR implements an inter-process readers writer lock, as suggested in #42.

I tried to stay very close to the existing code, in particular the structure, naming conventions, supported versions and the API. I took a bit more liberties with refreshing the documentation and README file, as well as fixed travis and added a gitignore.

I'm a bit unhappy that the intersection of windows and unix lock features is very small, but I don't know what to do about that apart from trying to build a readers writer locks myself, from lower level primitives. I'm not sure it is easy to do that.

Let me know what you think!

@psarka
Copy link
Collaborator Author

psarka commented Oct 27, 2020

@harlowja I'm waiting for this PR for my personal project, so I thought, maybe you need a hand with maintaining fasteners in general? I see many issues and PRs waiting, I could help out. Feel free to drop me an email at paulius.sarka@gmail.com.

@harlowja
Copy link
Owner

Ya, ownership is more than welcome :)

@psarka
Copy link
Collaborator Author

psarka commented Oct 27, 2020

Cool! How can I get started?

@harlowja
Copy link
Owner

Hmmm, guess we need some kind of CODEOWNERS file with u in it?

@psarka
Copy link
Collaborator Author

psarka commented Oct 27, 2020

As I understand from the docs, CODEOWNERS is optional. I think inviting me as a collaborator shoud be enough: https://docs.github.com/en/free-pro-team@latest/github/setting-up-and-managing-your-github-user-account/inviting-collaborators-to-a-personal-repository

@harlowja
Copy link
Owner

Ah, ok, that works to.

@harlowja
Copy link
Owner

U've been invited.

@psarka psarka mentioned this pull request Nov 1, 2020
@harlowja
Copy link
Owner

harlowja commented Nov 8, 2020

Resolve conflicts?

@psarka
Copy link
Collaborator Author

psarka commented Nov 8, 2020

Done 👍

@psarka psarka merged commit e0b1732 into harlowja:master Nov 9, 2020
@psarka psarka deleted the rwlock3 branch November 9, 2020 08:13
@harlowja
Copy link
Owner

harlowja commented Nov 9, 2020

Nice, I'm not sure if its possible to have travis update pypi, might be nice to do that; because it was just done by me before, lol

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants