-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lmplements the inter-process readers writer lock #50
Conversation
@harlowja I'm waiting for this PR for my personal project, so I thought, maybe you need a hand with maintaining fasteners in general? I see many issues and PRs waiting, I could help out. Feel free to drop me an email at paulius.sarka@gmail.com. |
Ya, ownership is more than welcome :) |
Cool! How can I get started? |
Hmmm, guess we need some kind of CODEOWNERS file with u in it? |
As I understand from the docs, CODEOWNERS is optional. I think inviting me as a collaborator shoud be enough: https://docs.github.com/en/free-pro-team@latest/github/setting-up-and-managing-your-github-user-account/inviting-collaborators-to-a-personal-repository |
Ah, ok, that works to. |
U've been invited. |
Resolve conflicts? |
Done 👍 |
Nice, I'm not sure if its possible to have travis update pypi, might be nice to do that; because it was just done by me before, lol |
This PR implements an inter-process readers writer lock, as suggested in #42.
I tried to stay very close to the existing code, in particular the structure, naming conventions, supported versions and the API. I took a bit more liberties with refreshing the documentation and README file, as well as fixed travis and added a gitignore.
I'm a bit unhappy that the intersection of windows and unix lock features is very small, but I don't know what to do about that apart from trying to build a readers writer locks myself, from lower level primitives. I'm not sure it is easy to do that.
Let me know what you think!