Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup evm to geth v1.9.9 Muir Glacier #3356

Merged
merged 10 commits into from
Sep 26, 2020
Merged

Conversation

rlan35
Copy link
Contributor

@rlan35 rlan35 commented Sep 20, 2020

@codecov
Copy link

codecov bot commented Sep 20, 2020

Codecov Report

Merging #3356 into main will increase coverage by 7.98%.
The diff coverage is 80.55%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3356      +/-   ##
==========================================
+ Coverage   33.66%   41.64%   +7.98%     
==========================================
  Files         212      174      -38     
  Lines       21983    15288    -6695     
==========================================
- Hits         7401     6367    -1034     
+ Misses      13957     8418    -5539     
+ Partials      625      503     -122     
Impacted Files Coverage Δ
core/types/tx_errorsink.go 0.00% <0.00%> (ø)
core/vm/common.go 39.28% <0.00%> (+1.19%) ⬆️
core/vm/evm.go 18.82% <0.00%> (+12.19%) ⬆️
core/vm/gas.go 0.00% <0.00%> (ø)
core/vm/logger.go 42.42% <ø> (ø)
core/vm/memory.go 33.33% <ø> (ø)
core/vm/memory_table.go 0.00% <0.00%> (ø)
core/vm/opcodes.go 0.00% <ø> (ø)
core/vm/stack.go 55.55% <ø> (+12.69%) ⬆️
staking/types/messages.go 100.00% <ø> (ø)
... and 58 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1b66674...99ae81d. Read the comment docs.

@rlan35
Copy link
Contributor Author

rlan35 commented Sep 26, 2020

Tested running the binary on mainnet to sync for the last 10k blocks. Things work fine.

Copy link
Contributor

@JackyWYX JackyWYX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rlan35 rlan35 merged commit 4452b36 into harmony-one:main Sep 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants