FFM-9930 Fix 403 when posting metrics for new env #220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**What** - Fixes a bug where we'd get a 403 if we created a new environment while the Proxy was running and the Proxy tried to forward metrics for that environment to Saas. **Why** - When a new env gets created we refresh the auth token that the proxy uses to commuincate with Saas so that it has the new env in the claims. However in the metrics service we were still using the old token that was fetched on startup which meant the metrics request for the new env would get a 403 from Saas. **Testing** - Manually tested locally
akiraqb
approved these changes
Nov 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Why
Testing