Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(FFM-11532) Add beta AND rule support #312

Merged
merged 2 commits into from
Jun 4, 2024
Merged

(FFM-11532) Add beta AND rule support #312

merged 2 commits into from
Jun 4, 2024

Conversation

conormurray95
Copy link
Contributor

@conormurray95 conormurray95 commented May 30, 2024 •
edited
Loading

Changes
Add support for segment AND functionality.
This involves:

  • Adding a beta flag which can optionally be set to true for proxy users (this will eventually be removed and become the default behaviour once it's GA).
  • Bump go sdk to latest to pull in the AND changes
  • Only serve servingRules to sdks if and-rules flag enabled in proxy AND rules=v2 flag set by incoming sdk request, otherwise return old form rules to match SaaS behaviour.

Testing

  • E2E and unit tests added for AND rule behaviour
  • Tested against QA for rules=v2 sdk requests, no rules header requests, evaluations with/without and rules enabled for proxy, making updates etc

@conormurray95 conormurray95 force-pushed the FFM-11532 branch 6 times, most recently from cf2b34f to d1f47d2 Compare May 31, 2024 13:53
jcox250
jcox250 approved these changes Jun 4, 2024
View reviewed changes
Copy link
Contributor

@jcox250 jcox250 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor question other than that looks good

@conormurray95 conormurray95 merged commit 66505f7 into v2 Jun 4, 2024
5 checks passed
@jcox250 jcox250 deleted the FFM-11532 branch October 7, 2024 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcox250 jcox250 jcox250 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@conormurray95 @jcox250