Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FFM-5354] Fixes compatibility with Ruby 2.6 #7

Merged
merged 2 commits into from
Nov 18, 2022
Merged

[FFM-5354] Fixes compatibility with Ruby 2.6 #7

merged 2 commits into from
Nov 18, 2022

Conversation

bmjen
Copy link
Contributor

@bmjen bmjen commented Nov 18, 2022

WHAT:
This SDK claims compatibility with Ruby 2.6 on Rubygems, but was not able to be built on Ruby 2.6.

FIX:
Removed the unneeded pp dependency that prevented the gem from installing on Ruby 2.6.

@swarmia
Copy link

swarmia bot commented Nov 18, 2022

Copy link
Collaborator

@davejohnston davejohnston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bmjen bmjen merged commit 88b3c0e into main Nov 18, 2022
@bmjen bmjen deleted the FFM-5354 branch November 18, 2022 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants