[FFM-5478]: Ruby SDK failed to cache some flags due to encoding #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ Linked to Bug FFM-5478 · Ruby SDK file cache fails to store certain strings |
Remove the file cache as it is not required and caused bugs. Ensure the segments are stored using set_segment instead of set_flag on startup Add the latest evaluation tests The Ruby SDK was failing to store some flags in its cache on startup, this meant the SDK would not function as expected. This only seemed to be a problem for the file cache, rather than in mem cache. The file cache could only handle UTF-8 data. There was also a bug during startup where set_flag was being called in place of set_segment, which meant no group data was stored in the cache. The evaluation tests were included to help test and verify the above fixes.
davejohnston
force-pushed
the
FFM-5478
branch
from
9f1ce0a
to
f65bcb6
Compare
erdirowlands
approved these changes
Nov 22, 2022
bmjen
approved these changes
Nov 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the file cache as it is not required and caused bugs. Ensure the segments are stored using set_segment instead of set_flag on startup Add the latest evaluation tests
The Ruby SDK was failing to store some flags in its cache on startup, this meant the SDK would not function as expected. This only seemed to be a problem for the file cache, rather than in mem
cache. The file cache could only handle UTF-8 data.
There was also a bug during startup where set_flag was being called in place of set_segment, which meant no group data was stored in the cache.
The evaluation tests were included to help test and verify the above fixes.