-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
prduct is not exists then display not found #391
prduct is not exists then display not found #391
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@harshalhonde21 ,check it and merge it as per #334 |
Hey @harshalhonde21 , |
the design of that card you add after dummy search which no match the product it is not matches the design of website do change like that |
Can you help me the which type of ui you want |
it should match our whole theme |
Tell me you want to text type or img choose one |
Hey @harshalhonde21 , i change that as you say now check it and merged it also add the label as per issue no 334 |
Hey @harshalhonde21 , |
@harshalhonde21 let me know its the match you looking for |
sorry for late reply @sanjay-kv and @Varsani2520 it's very difficult to handle all the project single handed @sanjay-kv there is no mentor is assigned to make then is it my problem that you didn't assign the active mentor to my problem then also i handle the project very good but some misses |
@Varsani2520 I say you to match the image to ui so do that i will merge it |
i think this should match with ui |
I mean just design the empty product image in adobe or canva and place there no need of text there the image should show that there is no product for this search |
you want to show me on the real screen on the product page at website don't show like that |
ok |
@harshalhonde21 now you check it |
see the image is not visible check it and don't raise the changes if you are not done any thing |
its not looking well because of gif first off all dont use gif and see the below image it direactly understood that what image says add like this image it will looks great |
ok |
Hey @harshalhonde21 ,i added as you say image instead of gif : |
dont add same image i say you make image like that which indicate that no item are availabe of this search |
ok I understood |
it is cart image the image can be added of reference like mart |
i update the empty state of products kindly check this and merge it |
…ctastyle into prduct-is-not-exists-then-display-not-found
…/github.com/Varsani2520/EcommerceSpectastyle into prduct-is-not-exists-then-display-not-found
|
pr is closed as not follow the instruction do with removing of conflicts and raise another PR |
Related Issue
[Cite any related issue(s) this pull request addresses. If none, simply state “None”]
prduct is not exists then display not found #334
Description
[Please include a brief description of the changes or features added]
prduct is not exists then display not found
Type of PR
Screenshots / videos (if applicable)
[Attach any relevant screenshots or videos demonstrating the changes]
Checklist:
Additional context:
[Include any additional information or context that might be helpful for reviewers.]