Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prduct is not exists then display not found #391

Closed
wants to merge 11 commits into from
Closed

prduct is not exists then display not found #391

wants to merge 11 commits into from

Conversation

Varsani2520
Copy link

Related Issue

[Cite any related issue(s) this pull request addresses. If none, simply state “None”]
prduct is not exists then display not found #334

Description

[Please include a brief description of the changes or features added]
prduct is not exists then display not found

Type of PR

  • Bug fix
  • Feature enhancement
  • Documentation update
  • Other (specify): _______________

Screenshots / videos (if applicable)

[Attach any relevant screenshots or videos demonstrating the changes]
image

Checklist:

  • I have performed a self-review of my code
  • I have read and followed the Contribution Guidelines.
  • I have tested the changes thoroughly before submitting this pull request.
  • I have provided relevant issue numbers, screenshots, and videos after making the changes.
  • I have commented my code, particularly in hard-to-understand areas.

Additional context:

[Include any additional information or context that might be helpful for reviewers.]

Copy link

vercel bot commented Jun 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ecommerce-spectastyle ❌ Failed (Inspect) Jun 28, 2024 1:30pm
ecommerce-spectastyle-9yav ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 28, 2024 1:30pm

@Varsani2520
Copy link
Author

@harshalhonde21 ,check it and merge it as per #334

@Varsani2520
Copy link
Author

Hey @harshalhonde21 ,
please check it and merged it
also add the label

@harshalhonde21
Copy link
Owner

the design of that card you add after dummy search which no match the product it is not matches the design of website do change like that

@Varsani2520
Copy link
Author

Can you help me the which type of ui you want

@harshalhonde21
Copy link
Owner

it should match our whole theme

@Varsani2520
Copy link
Author

Tell me you want to text type or img choose one

@Varsani2520
Copy link
Author

Hey @harshalhonde21 , i change that as you say now check it and merged it also add the label as per issue no 334

@Varsani2520
Copy link
Author

Hey @harshalhonde21 ,
check it and merged it as soon as possible

@sanjay-kv
Copy link

@harshalhonde21 let me know its the match you looking for

@harshalhonde21
Copy link
Owner

sorry for late reply @sanjay-kv and @Varsani2520 it's very difficult to handle all the project single handed @sanjay-kv there is no mentor is assigned to make then is it my problem that you didn't assign the active mentor to my problem then also i handle the project very good but some misses

@harshalhonde21
Copy link
Owner

Hey @harshalhonde21 , check it and merged it as soon as possible

@Varsani2520 I say you to match the image to ui so do that i will merge it

@Varsani2520
Copy link
Author

@harshalhonde21

i think this should match with ui
can you please tell me what kind of changes you need because i already completed empty state that match with your website ui

image

@harshalhonde21
Copy link
Owner

@harshalhonde21

i think this should match with ui can you please tell me what kind of changes you need because i already completed empty state that match with your website ui

image

I mean just design the empty product image in adobe or canva and place there no need of text there the image should show that there is no product for this search

@Varsani2520
Copy link
Author

@harshalhonde21 ,

how is it
image

@harshalhonde21
Copy link
Owner

@harshalhonde21 ,

how is it image

you want to show me on the real screen on the product page at website don't show like that

@Varsani2520
Copy link
Author

ok

@Varsani2520
Copy link
Author

@harshalhonde21 now you check it

@harshalhonde21
Copy link
Owner

@harshalhonde21 now you check it

image

see the image is not visible check it and don't raise the changes if you are not done any thing

@harshalhonde21
Copy link
Owner

@harshalhonde21

check this , i update code

image

its not looking well because of gif first off all dont use gif and see the below image it direactly understood that what image says

image

add like this image it will looks great

@Varsani2520
Copy link
Author

ok

@Varsani2520
Copy link
Author

Hey @harshalhonde21 ,i added as you say image instead of gif :
image

@harshalhonde21
Copy link
Owner

Hey @harshalhonde21 ,i added as you say image instead of gif : image

dont add same image i say you make image like that which indicate that no item are availabe of this search

@Varsani2520
Copy link
Author

ok I understood

@Varsani2520
Copy link
Author

@harshalhonde21
image

@harshalhonde21
Copy link
Owner

@harshalhonde21 image

it is cart image the image can be added of reference like mart

@Varsani2520
Copy link
Author

@harshalhonde21

i update the empty state of products kindly check this and merge it

@harshalhonde21
Copy link
Owner

@harshalhonde21

i update the empty state of products kindly check this and merge it

  1. firstly there are conflicts in your PR resolve first
  2. change the image as it is cart image and there is no cart is is product showcase so research first what to add there

@harshalhonde21
Copy link
Owner

pr is closed as not follow the instruction do with removing of conflicts and raise another PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants