code refactoring for capabilities issue

harshit-bs · Aug 17, 2023 · 370c01e · 370c01e
1 parent 1306847
commit 370c01e
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 15 deletions.
diff --git a/lib/index.js b/lib/index.js
@@ -130,7 +130,13 @@ module.exports.createClient = function({
         .then(() => {
           return client.createSession({argv});
         })
-        .then(_ => {
+        .then((data) => {
+          if (this.settings.test_runner?.type === 'cucumber' && NightwatchEventHub.isAvailable) {
+            const NightwatchFormatter = require('./runner/test-runners/cucumber/nightwatch-format');
+
+            NightwatchFormatter.setCapabilities(data);
+          }
+
           return client.api;
         })
         .catch((error) => {

diff --git a/lib/transport/selenium-webdriver/index.js b/lib/transport/selenium-webdriver/index.js
@@ -11,8 +11,6 @@ const CDP = require('./cdp.js');
 const {colors} = Logger;
 const {isErrorResponse, checkLegacyResponse, throwDecodedError, WebDriverError} = error;
 
-const {NightwatchEventHub} = require('../../runner/eventHub.js');
-
 let _driverService = null;
 let _driver = null;
 
@@ -297,20 +295,11 @@ class Transport extends BaseTransport {
       this.__elementKey = elementKey;
       await this.showConnectInfo({startTime, host, port, start_process, sessionInfo});
 
-      if (this.settings.test_runner?.type === 'cucumber' && NightwatchEventHub.isAvailable) {
-        const NightwatchFormatter = require('../../runner/test-runners/cucumber/nightwatch-format.js');
-
-        NightwatchFormatter.setCapabilities({
-          sessionId,
-          capabilities,
-          host, 
-          port
-        });
-      }
-
       return {
         sessionId,
-        capabilities
+        capabilities,
+        host, 
+        port
       };
     } catch (err) {
       const error = this.handleConnectError(err);