Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Scoop.pageInfo to JSON summary #180

Merged
merged 2 commits into from
Aug 15, 2023
Merged

Add Scoop.pageInfo to JSON summary #180

merged 2 commits into from
Aug 15, 2023

Conversation

matteocargnelutti
Copy link
Collaborator

Adds a pageInfo property to Scoop.summary()'s output, which is reflected in the output of --json-summary-output.

rebeccacremona
rebeccacremona approved these changes Aug 15, 2023
View reviewed changes
Copy link
Contributor

@rebeccacremona rebeccacremona left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

I am curious: why remove favicon? Maybe because it's not text, I'm guessing?

@matteocargnelutti
Copy link
Collaborator Author

Thank you!

That's a good question!
pageInfo.favicon is actually an ArrayBuffer containing the bytes of the actual favicon (a reference to it, actually)
I don't think it would be too useful as part of the JSON summary to have base64-encoded PNG bytes 😅

@matteocargnelutti matteocargnelutti merged commit a25a4a8 into main Aug 15, 2023
4 checks passed
@matteocargnelutti matteocargnelutti deleted the add-page-info-to-json-summary branch August 15, 2023 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rebeccacremona rebeccacremona rebeccacremona approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@matteocargnelutti @rebeccacremona