HARVESTER: SR-IOV polish #698
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WuJun2016
reviewed
Apr 26, 2023
| return { numVFs: 0 }; | ||
| const numVFs = this.resources[0].spec?.numVFs || 1; | ||
|
|
||
| return { numVFs, numVFsHistory: clone(numVFs) }; |
| @@ -63,8 +65,18 @@ export default class SRIOVDevice extends SteveModel { | |||
| } | |||
|
|
|||
| async disableDevice() { | |||
| this.spec.numVFs = 0; | |||
| await this.save(); | |||
| const numVFsHistory = clone(this.spec.numVFs); | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
PR Checklist
Is this a multi-tenancy feature/bug?Yes, the relevant RBAC changes are at:Do we need to backport changes to the old Rancher UI, such as RKE1?Yes, the relevant PR is at:Are backend engineers aware of UI changes?Yes, the backend owner is:Occurred changes and/or fixed issues
Technical notes summary
Areas or cases that should be tested
Areas which could experience regressions
Screenshot/Video