[Doc] return object type on delete, not status
#5782
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m-ildefons
approved these changes
May 15, 2024
There was a problem hiding this comment.
LGTM.
This fixes the DELETE operation, but keep in mind that Kubernetes also knows a DELETECOLLECTION operation.
The way this works is that a delete request is issued, but the URL path does not contain a specific name for the DELETECOLLECTION operation, but rather a selector (like a label-selector) is passed as URL parameter. All objects that match this selector are then deleted in bulk.
The DELETECOLLECTION operation does indeed return a Status object.
As far as I can tell, we don't have this operation documented at all though.
|
Harvester API returns a list of VMs deleted when you call DELETECOLLECTION. But, as you said, that action isn’t documented |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #5781, #5528