Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

יצירה אוטומטית של ארגונים #101

Closed
niryariv opened this issue Nov 1, 2020 · 14 comments
Closed

יצירה אוטומטית של ארגונים #101

niryariv opened this issue Nov 1, 2020 · 14 comments
Assignees

Comments

@niryariv
Copy link

niryariv commented Nov 1, 2020

בתור התחלה:

  1. הרשות המקומית הרלבנטית (עיריה?)

  2. מדינת ישראל (פה אני מתייחס לכל המידע שנגרד מתוך דאטה.גוב ואחרים. יכול להיות שנכון יותר שזה יהיה ספק המידע הרלבנטי, למשל המשרד להגנת הסביבה או משרד הפנים וכו׳? מה דעתכם?)

cc @akariv

@OriHoch
Copy link
Contributor

OriHoch commented Nov 5, 2020

in #97 I added a default organization for the municipality, I think most datasets can be published under that organization. If there are other departments within the municipality (like the public library) they can have their own organization. I don't think scraped data should be under a different organization, I don't think it has any benefit to end-users. Filtering should be done using groups (תחומים) and tags

@niryariv niryariv assigned niryariv and unassigned OriHoch Nov 8, 2020
@niryariv
Copy link
Author

niryariv commented Nov 8, 2020

להגדיר ארגון עבור כל אחד מפריטי המידע, כדי שהמערכת תייצר אותו בזמן הייבוא

@niryariv
Copy link
Author

niryariv commented Nov 8, 2020

looking at the CKAN API it seems that we should be able to detect Org (with name, image, url etc) from the package itself, eg: https://opendataprod.br7.org.il/api/3/action/package_show?id=83d232f0-fc41-4638-acb5-2e37b3c5c7ff

But I can't get this to work on data.gov.il. Not sure if I'm missing something or data.gov.il is blocking this or it's a different API version. @OriHoch can you take a look? If this doesn't work I'll maintain it manually in a table instead.

@niryariv niryariv assigned OriHoch and unassigned niryariv Nov 8, 2020
@OriHoch
Copy link
Contributor

OriHoch commented Nov 8, 2020

yes, it's possible, but I don't think that's necessarily what you want to appear in the target site. for example, the organization for the corona data in odata is "גיא זומר"

@OriHoch
Copy link
Contributor

OriHoch commented Nov 8, 2020

you don't need to verify this using the CKAN API, you can just access the relevant dataset and see what is the linked organization on the relevant source website

@niryariv
Copy link
Author

niryariv commented Nov 8, 2020

you don't need to verify this using the CKAN API, you can just access the relevant dataset and see what is the linked organization on the relevant source website

you mean scraping the html?

@OriHoch
Copy link
Contributor

OriHoch commented Nov 8, 2020

I will use the API

@OriHoch
Copy link
Contributor

OriHoch commented Nov 11, 2020

please verify for each of the automatically created datasets if the organization from the source will be relevant as-is on the target

if not, which organization to create / use for that dataset

you can see on the source dataset's website the linked organization so you can verify it

@OriHoch OriHoch assigned niryariv and unassigned OriHoch Nov 11, 2020
@akariv
Copy link
Member

akariv commented Nov 11, 2020 via email

@niryariv
Copy link
Author

Works for me. @OriHoch let's just hard code מאגר מידע ממשלתי for anything that comes from data.gov.il

What do you guys think we should do with the odata COVID data?

@OriHoch
Copy link
Contributor

OriHoch commented Nov 12, 2020

no problem, what about logo, description of this organization? you could create this organization on test instance and configure it as an example

@akariv
Copy link
Member

akariv commented Nov 12, 2020 via email

@niryariv
Copy link
Author

@niryariv
Copy link
Author

closing for #138

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants