Rename variable and function names and add functional tests for booking workflows #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
vidya-ram
commented
Jan 31, 2017
vidya-ram
commented
- Rename variable and function names to follow camel case convention.
- Change boxoffice widget variable.
- Add currency format function to client side.
- Add functional tests for booking workflows using Casperjs
…ency formatting for all prices and amounts.
shreyas-satish
suggested changes
Feb 8, 2017
boxoffice/static/js/models/util.js
Outdated
| @@ -21,22 +21,22 @@ export const Util = { | |||
| } | |||
| } | |||
|
|
|||
| export const fetch = function(config){ | |||
| export const Fetch = function(config){ | |||
There was a problem hiding this comment.
Why is this capitalized? Capitals are usually reserved for constructors.
There was a problem hiding this comment.
Or for container objects.
boxoffice/static/js/models/util.js
Outdated
| return $.ajax({ | ||
| url: config.url, | ||
| type: 'POST', | ||
| dataType: 'json' | ||
| }); | ||
| } | ||
|
|
||
| export const scrollToElement = function(element, speed=500) { | ||
| export const ScrollToElement = function(element, speed=500) { |
There was a problem hiding this comment.
Same as above. This should be scrollToElement.
| {{#details:k,v}} | ||
| {{#if k !== 'logo'}} | ||
| <p class="section-title">{{k}}</p> | ||
| <div class="section-content">{{{details[k]}}}</div> | ||
| <p class="section-title">{{ k }}</p> |
| <p><span class="italic-title">Final amount:</span> {{ currency }}{{ final_amount }}</p> | ||
| <p><span class="italic-title">Base amount:</span> {{ formatCurrency(base_amount) }}</p> | ||
| <p><span class="italic-title">Discounted amount:</span> {{ formatCurrency(discounted_amount) }}</p> | ||
| <p><span class="italic-title">Final amount:</span> {{ formatCurrency(final_amount) }}</p> |
There was a problem hiding this comment.
Shouldn't base_amount, discounted_amount and final_amount also be in camelCase?
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.