Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change app init protocol #106

Closed
jace opened this issue May 4, 2017 · 0 comments
Closed

Change app init protocol #106

jace opened this issue May 4, 2017 · 0 comments

Comments

@jace
Copy link
Member

jace commented May 4, 2017

Coaster and hgapp currently require an app to be loaded and initialised in separate stages. The latter step has been a recurring source of conflict with the Flask extension ecosystem, which do not recognise a separate init step.

We should follow the crowd and switch. hasgeek/hgapp#6 documents the changes. Coaster will require some breaking changes to make this happen, and all apps will need to be updated. In recognition of this change, Coaster's version number will be bumped up to 0.6. Specifically:

  • coaster.manage will no longer accept env as a command line parameter.
  • coaster.manage will no longer accept init_for as an init parameter, nor will it be called.
  • coaster.app.init_app takes env as an optional parameter, reading it from the FLASK_ENV environment variable if unspecified, and defaulting to DEVELOPMENT.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant