This repository has been archived by the owner on Apr 28, 2020. It is now read-only.
Moving to Py3 #378
Merged
Moving to Py3 #378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jace
suggested changes
Feb 19, 2020
| key.encode('utf-8') if isinstance(key, unicode) else key, | ||
| value.encode('utf-8') if isinstance(value, unicode) else value, | ||
| key.encode('utf-8') if isinstance(key, str) else key, | ||
| value.encode('utf-8') if isinstance(value, str) else value, |
There was a problem hiding this comment.
Is .encode still required with urllib.parse?
There was a problem hiding this comment.
Seems so. works if we send string as well, but then urllib encodes it anyway.
There was a problem hiding this comment.
This is the only pending issue. I don't know enough to comment, so your call. If this is working, this PR can be merged.
There was a problem hiding this comment.
This function has a test and that's passing.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to hasgeek/hgapp#39