New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Does not work well with dark theme #14

Closed

targodan opened this issue Sep 15, 2020 · 4 comments

targodan commented Sep 15, 2020

Great plugin, sadly it does not work well with the dark theme.

The text in the table is barely readable and it somehow seems to mess with the theme of the disassembly view as well.

How to reproduce:

Click Options -> Colors and select theme "dark". Click Ok. (I did this way before installing the plugin)
Install the plugin
Open the view via View -> IFL

Strangely even applying the dark theme again does not set the disassembly view theme correctly.

Owner

hasherezade commented Sep 16, 2020

Thank you for reporting! I will fix it as soon as I get some free time.

GH-Rake commented Oct 6, 2020 •

edited

Loading

Where has this plugin been all my life? Can't live without it now

This is just a quick fix for dark mode, doesn't look pretty but at least you can read the text in the meantime.

Find and replace:
QtGui.QColor("khaki") -> QtGui.QColor("black")
QtGui.QColor("orange") -> QtGui.QColor("orangered")
QtGui.QColor("lightblue") -> QtGui.QColor("blue")

hasherezade added a commit that referenced this issue


          [BUGFIX] Improved visibility in the dark mode (Issue #14)

1e4e986

hasherezade added a commit that referenced this issue


          [BUGFIX] Fixed address hilighting in dark mode (Issue #14)

f84d804

hasherezade added a commit that referenced this issue


          [REFACT] Use DEFCOLOR from idc (Issue #14)

17f44c9

Owner

hasherezade commented Jan 5, 2021

It looks like this with my latest fixes:

dark:

light:

Owner

hasherezade commented Jan 6, 2021 •

edited

Loading

I made another update, hopefully it is better!

https://github.com/hasherezade/ida_ifl/releases/tag/v1.4.2.1 (Python3)
https://github.com/hasherezade/ida_ifl/releases/tag/v1.3.7.1 (Python2)

Preview:

dark

light

hasherezade closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment