docs: 13690 Added a design doc for `Ledger State API` #13730

imalygin · 2024-06-06T22:39:04Z

Description:

This design doc is a compilation of the following Notion pages:

State Refactor for State Proofs

Public Specified Merkle Tree & State

Public Merkle Tree API

Merkle tree to protobuf

Proposed Platform State Structure

Fixes #13690

Notes for reviewer:

Checklist

Documented (Code comments, README, etc.)
Tested (unit, integration, etc.)

github-actions · 2024-06-06T22:51:47Z

Node: HAPI Test (Crypto) Results

24 files 24 suites 13m 27s ⏱️
362 tests 362 ✅ 0 💤 0 ❌
369 runs 369 ✅ 0 💤 0 ❌

Results for commit 34efbae.

♻️ This comment has been updated with latest results.

github-actions · 2024-06-06T22:51:51Z

Node: HAPI Test (Node Death Reconnect) Results

3 tests 3 ✅ 6m 17s ⏱️
3 suites 0 💤
3 files 0 ❌

Results for commit 34efbae.

♻️ This comment has been updated with latest results.

github-actions · 2024-06-06T22:51:51Z

Node: HAPI Test (Misc) Results

51 files 51 suites 21m 40s ⏱️
357 tests 357 ✅ 0 💤 0 ❌
375 runs 375 ✅ 0 💤 0 ❌

Results for commit 34efbae.

♻️ This comment has been updated with latest results.

github-actions · 2024-06-06T22:51:56Z

Node: HAPI Test (Smart Contract) Results

73 files 73 suites 23m 52s ⏱️
623 tests 623 ✅ 0 💤 0 ❌
677 runs 677 ✅ 0 💤 0 ❌

Results for commit 34efbae.

♻️ This comment has been updated with latest results.

github-actions · 2024-06-06T22:51:57Z

Node: HAPI Test (Time Consuming) Results

19 tests 19 ✅ 23m 28s ⏱️
4 suites 0 💤
4 files 0 ❌

Results for commit 34efbae.

♻️ This comment has been updated with latest results.

github-actions · 2024-06-06T22:52:11Z

Node: HAPI Test (Restart) Results

3 tests 3 ✅ 7m 10s ⏱️
3 suites 0 💤
3 files 0 ❌

Results for commit 34efbae.

♻️ This comment has been updated with latest results.

github-actions · 2024-06-06T22:52:18Z

Node: Unit Test Results

1 540 files 1 540 suites 2h 42m 17s ⏱️
110 064 tests 110 005 ✅ 59 💤 0 ❌
118 374 runs 118 315 ✅ 59 💤 0 ❌

Results for commit 34efbae.

♻️ This comment has been updated with latest results.

github-actions · 2024-06-06T22:52:58Z

Node: HAPI Test (Token) Results

20 files 20 suites 5m 59s ⏱️
266 tests 266 ✅ 0 💤 0 ❌
341 runs 341 ✅ 0 💤 0 ❌

Results for commit 34efbae.

♻️ This comment has been updated with latest results.

codecov · 2024-06-06T22:54:05Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.27%. Comparing base (9973fae) to head (06d6061).
Report is 83 commits behind head on develop.

❗ Current head 06d6061 differs from pull request most recent head 34efbae

Please upload reports for the commit 34efbae to get more accurate results.

Additional details and impacted files

@@              Coverage Diff              @@
##             develop   #13730      +/-   ##
=============================================
- Coverage      67.58%   58.27%   -9.31%     
+ Complexity     36486    22080   -14406     
=============================================
  Files           3732     2883     -849     
  Lines         149767   109662   -40105     
  Branches       15571    11159    -4412     
=============================================
- Hits          101223    63910   -37313     
+ Misses         44179    42219    -1960     
+ Partials        4365     3533     -832

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

platform-sdk/docs/proposals/state-refactor/state-refactor.md

litt3

+1

platform-sdk/docs/proposals/001-merkle-state-api/001-merkle-state-api.md

anthony-swirldslabs

+1

anthony-swirldslabs

+1

kfa-aguda

+1

platform-sdk/docs/proposals/001-ledger-state-api/001-ledger-state-api.md

rbair23

+1

platform-sdk/docs/proposals/001-ledger-state-api/001-ledger-state-api.md

anthony-swirldslabs

+1

Signed-off-by: Austin Littley <austin@swirldslabs.com>

anthony-swirldslabs

+1

edward-swirldslabs

+0.99 - Do these changes need to be reflected in HIP anywhere?

hendrikebbers · 2024-06-27T13:58:54Z

+0.9 the proposal is great but I do not have enough knowledge of the technical topic to do +1

edward-swirldslabs

+1 the hip I asked about would come through block-streams at the very latest.

imalygin added Design Issue/PR for feature design documents. Platform Tickets pertaining to the platform labels Jun 6, 2024

imalygin self-assigned this Jun 6, 2024

imalygin requested review from a team as code owners June 6, 2024 22:39

imalygin requested review from cody-littley, artemananiev, mxtartaglia-sl and OlegMazurov June 6, 2024 22:39

imalygin added this to the v0.52 milestone Jun 6, 2024

imalygin changed the title ~~doc: 13690 Added a design doc for Refactor for State Proofs~~ docs: 13690 Added a design doc for Refactor for State Proofs Jun 6, 2024

poulok marked this pull request as draft June 7, 2024 14:17

litt3 reviewed Jun 7, 2024

View reviewed changes

imalygin marked this pull request as ready for review June 11, 2024 15:27

litt3 previously approved these changes Jun 11, 2024

View reviewed changes

platform-sdk/docs/proposals/001-merkle-state-api/001-merkle-state-api.md Outdated Show resolved Hide resolved

platform-sdk/docs/proposals/001-merkle-state-api/001-merkle-state-api.md Outdated Show resolved Hide resolved

anthony-swirldslabs previously approved these changes Jun 11, 2024

View reviewed changes

imalygin dismissed stale reviews from anthony-swirldslabs and litt3 via f96e394 June 11, 2024 19:26

anthony-swirldslabs previously approved these changes Jun 11, 2024

View reviewed changes

litt3 dismissed poulok’s stale review via 9f1d283 June 21, 2024 18:40

litt3 requested review from jasperpotts, rbair23, hendrikebbers, cody-littley, edward-swirldslabs, poulok and anthony-swirldslabs June 21, 2024 18:40

litt3 changed the title ~~docs: 13690 Added a design doc for Public Merkle State API~~ docs: 13690 Added a design doc for Ledger State API Jun 21, 2024

kfa-aguda previously approved these changes Jun 21, 2024

View reviewed changes

rbair23 reviewed Jun 21, 2024

View reviewed changes

platform-sdk/docs/proposals/001-ledger-state-api/001-ledger-state-api.md Outdated Show resolved Hide resolved

rbair23 previously approved these changes Jun 21, 2024

View reviewed changes

platform-sdk/docs/proposals/001-ledger-state-api/001-ledger-state-api.md Show resolved Hide resolved

anthony-swirldslabs previously approved these changes Jun 21, 2024

View reviewed changes

Fix param type

e4cf729

Signed-off-by: Austin Littley <austin@swirldslabs.com>

litt3 dismissed stale reviews from anthony-swirldslabs, rbair23, and kfa-aguda via e4cf729 June 24, 2024 21:02

anthony-swirldslabs approved these changes Jun 24, 2024

View reviewed changes

Merge branch 'develop' into 13690-design-doc

06d6061

poulok approved these changes Jun 26, 2024

View reviewed changes

litt3 requested review from rbair23 and kfa-aguda June 26, 2024 14:22

edward-swirldslabs reviewed Jun 26, 2024

View reviewed changes

kfa-aguda approved these changes Jun 26, 2024

View reviewed changes

Merge branch 'develop' into 13690-design-doc

34efbae

edward-swirldslabs approved these changes Jun 28, 2024

View reviewed changes

litt3 merged commit 4ddd52b into develop Jul 1, 2024
40 of 41 checks passed

litt3 deleted the 13690-design-doc branch July 1, 2024 12:49

imalygin mentioned this pull request Jul 1, 2024

feat: 13135 Added PlatformState protobuf representation hashgraph/hedera-protobufs#349

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

docs: 13690 Added a design doc for `Ledger State API` #13730

docs: 13690 Added a design doc for `Ledger State API` #13730

imalygin commented Jun 6, 2024 •

edited

Loading

github-actions bot commented Jun 6, 2024 •

edited

Loading

github-actions bot commented Jun 6, 2024 •

edited

Loading

github-actions bot commented Jun 6, 2024 •

edited

Loading

github-actions bot commented Jun 6, 2024 •

edited

Loading

github-actions bot commented Jun 6, 2024 •

edited

Loading

github-actions bot commented Jun 6, 2024 •

edited

Loading

github-actions bot commented Jun 6, 2024 •

edited

Loading

github-actions bot commented Jun 6, 2024 •

edited

Loading

codecov bot commented Jun 6, 2024 •

edited

Loading

litt3 left a comment

anthony-swirldslabs left a comment

anthony-swirldslabs left a comment

kfa-aguda left a comment

rbair23 left a comment

anthony-swirldslabs left a comment

anthony-swirldslabs left a comment

edward-swirldslabs left a comment

hendrikebbers commented Jun 27, 2024

edward-swirldslabs left a comment

docs: 13690 Added a design doc for Ledger State API #13730

docs: 13690 Added a design doc for Ledger State API #13730

Conversation

imalygin commented Jun 6, 2024 • edited Loading

github-actions bot commented Jun 6, 2024 • edited Loading

Node: HAPI Test (Crypto) Results

github-actions bot commented Jun 6, 2024 • edited Loading

Node: HAPI Test (Node Death Reconnect) Results

github-actions bot commented Jun 6, 2024 • edited Loading

Node: HAPI Test (Misc) Results

github-actions bot commented Jun 6, 2024 • edited Loading

Node: HAPI Test (Smart Contract) Results

github-actions bot commented Jun 6, 2024 • edited Loading

Node: HAPI Test (Time Consuming) Results

github-actions bot commented Jun 6, 2024 • edited Loading

Node: HAPI Test (Restart) Results

github-actions bot commented Jun 6, 2024 • edited Loading

Node: Unit Test Results

github-actions bot commented Jun 6, 2024 • edited Loading

Node: HAPI Test (Token) Results

codecov bot commented Jun 6, 2024 • edited Loading

Codecov Report

litt3 left a comment

Choose a reason for hiding this comment

anthony-swirldslabs left a comment

Choose a reason for hiding this comment

anthony-swirldslabs left a comment

Choose a reason for hiding this comment

kfa-aguda left a comment

Choose a reason for hiding this comment

rbair23 left a comment

Choose a reason for hiding this comment

anthony-swirldslabs left a comment

Choose a reason for hiding this comment

anthony-swirldslabs left a comment

Choose a reason for hiding this comment

edward-swirldslabs left a comment

Choose a reason for hiding this comment

hendrikebbers commented Jun 27, 2024

edward-swirldslabs left a comment

Choose a reason for hiding this comment

docs: 13690 Added a design doc for `Ledger State API` #13730

docs: 13690 Added a design doc for `Ledger State API` #13730

imalygin commented Jun 6, 2024 •

edited

Loading

github-actions bot commented Jun 6, 2024 •

edited

Loading

github-actions bot commented Jun 6, 2024 •

edited

Loading

github-actions bot commented Jun 6, 2024 •

edited

Loading

github-actions bot commented Jun 6, 2024 •

edited

Loading

github-actions bot commented Jun 6, 2024 •

edited

Loading

github-actions bot commented Jun 6, 2024 •

edited

Loading

github-actions bot commented Jun 6, 2024 •

edited

Loading

github-actions bot commented Jun 6, 2024 •

edited

Loading

codecov bot commented Jun 6, 2024 •

edited

Loading