Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(HIP-904): Token Reject #991

Merged
merged 13 commits into from
Jul 16, 2024
Merged

feat(HIP-904): Token Reject #991

merged 13 commits into from
Jul 16, 2024

Conversation

0xivanov
Copy link
Contributor

@0xivanov 0xivanov commented Jun 27, 2024 •
edited
Loading

Description:
Implementation of TokenRejectTransaction

Related issue(s):

Fixes #960 #992

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

0xivanov added 2 commits June 25, 2024 13:38
@0xivanov
feat: initial implementation
581b801 
Signed-off-by: Ivan Ivanov <ivanivanov.ii726@gmail.com>
@0xivanov
test: add more test cases
ba70239 
Signed-off-by: Ivan Ivanov <ivanivanov.ii726@gmail.com>
@0xivanov 0xivanov self-assigned this Jun 27, 2024
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@codecov Codecov
Copy link

codecov bot commented Jun 27, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 78.65169% with 76 lines in your changes missing coverage. Please review.

Project coverage is 73.52%. Comparing base (529e0c7) to head (ab0951c).

Files Patch % Lines
token_reject_flow.go 71.42% 35 Missing and 13 partials ⚠️
token_reject_transaction.go 82.50% 24 Missing and 4 partials ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #991      +/-   ##
==========================================
+ Coverage   73.41%   73.52%   +0.10%     
==========================================
  Files         166      168       +2     
  Lines       23392    23748     +356     
==========================================
+ Hits        17174    17460     +286     
- Misses       5528     5581      +53     
- Partials      690      707      +17

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

0xivanov added 6 commits July 5, 2024 10:43
@0xivanov
feat: initial implementation
d4a7022 
Signed-off-by: Ivan Ivanov <ivanivanov.ii726@gmail.com>
@0xivanov
test: initial tests impl
6ac796c 
Signed-off-by: Ivan Ivanov <ivanivanov.ii726@gmail.com>
@0xivanov
test: add tests
e8698f8 
Signed-off-by: Ivan Ivanov <ivanivanov.ii726@gmail.com>
@0xivanov
test: add more e2e tests
53bb127 
Signed-off-by: Ivan Ivanov <ivanivanov.ii726@gmail.com>
@0xivanov
Merge branch 'main' into 960-token-reject-transaction
e8b7362
@0xivanov
chore: fix merge conflicts
51ca761 
Signed-off-by: Ivan Ivanov <ivanivanov.ii726@gmail.com>
0xivanov added 2 commits July 12, 2024 13:46
@0xivanov
chore: add token reject flow
4032991 
Signed-off-by: Ivan Ivanov <ivanivanov.ii726@gmail.com>
@0xivanov
chore: increase coverage
32e1da0 
Signed-off-by: Ivan Ivanov <ivanivanov.ii726@gmail.com>
@0xivanov 0xivanov marked this pull request as ready for review July 12, 2024 11:33
@0xivanov 0xivanov requested review from a team as code owners July 12, 2024 11:33
gsstoykov
gsstoykov reviewed Jul 12, 2024
View reviewed changes
token_reject_transaction.go Outdated Show resolved Hide resolved
nft_id.go Outdated Show resolved Hide resolved
token_id.go Outdated Show resolved Hide resolved
token_reject_transaction.go Outdated Show resolved Hide resolved
token_reject_transaction.go Outdated Show resolved Hide resolved
@0xivanov
chore: add example and address PR feedback
824dc7e 
Signed-off-by: Ivan Ivanov <ivanivanov.ii726@gmail.com>
@0xivanov 0xivanov requested review from thenswan and gsstoykov July 15, 2024 10:09
@0xivanov
chore: address PR feedback
4e79937 
Signed-off-by: Ivan Ivanov <ivanivanov.ii726@gmail.com>
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
6 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
1.8% Duplication on New Code

See analysis details on SonarCloud

@0xivanov 0xivanov merged commit 1d80801 into main Jul 16, 2024
9 checks passed
@0xivanov 0xivanov deleted the 960-token-reject-transaction branch July 16, 2024 07:43
This was referenced Jul 17, 2024
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gsstoykov gsstoykov gsstoykov approved these changes

@thenswan thenswan thenswan approved these changes

@rwalworth rwalworth Awaiting requested review from rwalworth rwalworth was automatically assigned from hashgraph/hedera-sdk

@SimiHunjan SimiHunjan Awaiting requested review from SimiHunjan SimiHunjan was automatically assigned from hashgraph/hedera-sdk-go-maintainers

@agadzhalov agadzhalov Awaiting requested review from agadzhalov agadzhalov was automatically assigned from hashgraph/hedera-sdk-go-maintainers

Assignees

@0xivanov 0xivanov

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add HIP-904: TokenRejectTransaction
3 participants
@0xivanov @thenswan @gsstoykov