Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do type check of function parameters #45

Closed
Tracked by #50
leninmehedy opened this issue Nov 13, 2023 · 2 comments · Fixed by #217
Closed
Tracked by #50

Do type check of function parameters #45

leninmehedy opened this issue Nov 13, 2023 · 2 comments · Fixed by #217
Assignees
@JeffreyDallas
Labels
Feature Enhancement Enhancing an existing feature driven by business requirements. Typically backwards compatible. released on @0.24.x released

Comments

@leninmehedy
Copy link
Member

leninmehedy commented Nov 13, 2023 •
edited

Ideally we need to ensure the type is correct although in Javascript type check is tricky.

Here is an example how we do it currently: https://github.com/hashgraph/solo/blob/main/src/commands/base.mjs#L35
In addition to null check as above, we have to use instanceof and typeof to ensure the type of the arguments similar to how we usually to it in Java.

We shall need to update the doc block so that class docs are generated correctly, so this has dependency on: #39
@leninmehedy leninmehedy added the Bug A error that causes the feature to behave differently than what was expected based on design docs label Nov 13, 2023
@leninmehedy leninmehedy assigned leninmehedy and unassigned qnswirlds Dec 20, 2023
@leninmehedy leninmehedy added Feature Enhancement Enhancing an existing feature driven by business requirements. Typically backwards compatible. and removed Bug A error that causes the feature to behave differently than what was expected based on design docs labels Feb 2, 2024
@nathanklick nathanklick transferred this issue from hashgraph/full-stack-testing Feb 20, 2024
@nathanklick nathanklick changed the title CLI: Do type check of function parameters Do type check of function parameters Feb 20, 2024
@nathanklick nathanklick mentioned this issue Feb 20, 2024
Open
@JeffreyDallas JeffreyDallas mentioned this issue Apr 9, 2024
Merged
@swirlds-automation
Copy link
Contributor

🎉 This issue has been resolved in version 0.24.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@swirlds-automation
Copy link
Contributor

🎉 This issue has been resolved in version 0.24.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JeffreyDallas JeffreyDallas

Labels
Feature Enhancement Enhancing an existing feature driven by business requirements. Typically backwards compatible. released on @0.24.x released
Projects
Solo
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: adding some type check hashgraph/solo
4 participants
@leninmehedy @JeffreyDallas @qnswirlds @swirlds-automation