Add projects API #437
Merged
Add projects API #437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anubhavmishra
suggested changes
Nov 21, 2023
Comment on lines
+345
to
+346
| {"/api/v1/products", apiv2.ProductsHandler(srv)}, | ||
| {"/api/v1/projects", apiv2.ProjectsHandler(srv)}, |
There was a problem hiding this comment.
Not sure why we would add v1 endpoints for projects given it is a brand new feature? Is this to support some type of backwards incompatibility?
There was a problem hiding this comment.
The API version is (more or less, currently, but there's a draft PR #399 that might make this explicit) global for all frontend fetch calls, so I wanted to make sure that this is supported in v1 of the API as well (while it exists). The same code is used for both API versions.
anubhavmishra
approved these changes
Nov 21, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds APIs for creating and updating projects and their associated related resources (both API versions
v1andv2are handled by the same code).New API Endpoints
/api/v1/projects:GET,POST/api/v1/projects/{project_id}:GET,PATCH/api/v1/projects/{project_id}/related-resources:GET,POST,PUT/api/v2/projects:GET,POST/api/v2/projects/{project_id}:GET,PATCH/api/v2/projects/{project_id}/related-resources:GET,POST,PUT