Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check for dialogs when using FloatingUI + renderOut #502

Merged
merged 2 commits into from
Dec 14, 2023
Merged

Check for dialogs when using FloatingUI + renderOut #502

merged 2 commits into from
Dec 14, 2023

Conversation

jeffdaley
Copy link
Contributor

@jeffdaley jeffdaley commented Dec 14, 2023 •
edited
Loading

Adds a check for dialog in Floating UI's renderOut logic. Normally we render out to the bottom of the DOM and use z-index for layering, but because dialog is part of the top layer we need to render into it to overlay it.

@jeffdaley jeffdaley marked this pull request as ready for review December 14, 2023 14:21
@jeffdaley jeffdaley requested a review from a team as a code owner December 14, 2023 14:21
jfreda
jfreda approved these changes Dec 14, 2023
View reviewed changes
web/app/components/floating-u-i/content.ts Outdated Show resolved Hide resolved
@jeffdaley jeffdaley merged commit 60dabb1 into main Dec 14, 2023
2 checks passed
@jeffdaley jeffdaley deleted the jeffdaley/floating-ui-content branch December 14, 2023 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jfreda jfreda jfreda approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jeffdaley @jfreda