Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove TODO comment #518

Merged
merged 174 commits into from
Dec 19, 2023
Merged

Remove TODO comment #518

merged 174 commits into from
Dec 19, 2023

Conversation

jeffdaley
Copy link
Contributor

Sorry, meant to remove it in #414

@jeffdaley
Tweak HDS types
4c93e39
@jeffdaley
Empty state button
b062b70
@jeffdaley
Merge branch 'jeffdaley/glint-types' into jeffdaley/projects-in-sidebar
b8f187a
@jeffdaley
Add modifier types; update templates
bfdc1cc
@jeffdaley
Add EmptyStateAddButton component
c840a9e
@jeffdaley
Add test, tweak property name
e43e9c6
@jeffdaley
Merge branch 'jeffdaley/empty-state-add-button' into jeffdaley/projec…
213a6d8 
…ts-in-sidebar
@jeffdaley
Start of AddOrCreate component
9a9b663
@jeffdaley
Merge branch 'main' into jeffdaley/projects-in-sidebar
a5a6c13
@jeffdaley
Tweak Project factory
e95103e
@jeffdaley
Merge branch 'jeffdaley/project-factory' into jeffdaley/projects-in-s…
d5e501e 
…idebar
@jeffdaley
Sidebar styles; add onNextRunLoop to autofocus
2c0f69a
@jeffdaley
Work on sidebar project tile
f46a015
@jeffdaley
Add ProjectIndex and Resource components
ef3a5bb
@jeffdaley
Add large size to PersonAvatar
db17ae7
@jeffdaley
Project index files
fa38de5
@jeffdaley
Merge branch 'jeffdaley/large-avatar' into jeffdaley/project-index-2
b98d5ab
@jeffdaley
Remove pauseTest
d31b432
@jeffdaley
Modal contents
4f0ffb0
@jeffdaley
Modal form
13d45b9
@jeffdaley
Merge branch 'main' into jeffdaley/projects-in-sidebar
df78eb9
@jeffdaley
Renames and types for added clarity
1a79882
@jeffdaley
Merge branch 'main' into jeffdaley/project-index-2
6ce52bc
@jeffdaley
Cleanup and documentation
0864095
@jeffdaley
Console.log cleanup
830b807
@jeffdaley
Post-meeting endpoint tweaks
ac50368
@jeffdaley
Basic "clear type errors" commit
0bc341e
@jeffdaley
Mark todos; cleanup Mirage config
2c67252
@jeffdaley
Add JiraIssue and HermesDocument
d98a188
@jeffdaley
Cleanup
9128372
@jeffdaley
Merge branch 'main' into jeffdaley/projects-in-sidebar
7fb6afe
@jeffdaley
Tweak "creating project..."
735b385
@jeffdaley
Move formatRelatedHermesDocument
b739eee
@jeffdaley
Start tests
ba95de4
@jeffdaley
test work
4c122a9
@jeffdaley
Merge branch 'main' into jeffdaley/projects-in-sidebar
22e0f17
@jeffdaley
Improve Mirage responses
56e6b3f
@jeffdaley
Revert FormsService
ab94c81
@jeffdaley
Refactor AddToOrCreate to use one modal
88c06d3
@jeffdaley
Form gap tweak
73030a4
@jeffdaley
WIP attached Jira affordance
232c228
@jeffdaley
Fix broken tests
f2d19c0
@jeffdaley
Write component tests
0f7f166
@jeffdaley
Update project-form.ts
d425d44
@jeffdaley
Fix test
a4b3a84
@jeffdaley
Section header test
d9e8fc4
@jeffdaley
Refactor isModal layouts
287d6ac
@jeffdaley
Whitespace edits
da25921
@jeffdaley
Cleanup and revert some changes
8230a81
@jeffdaley
Jira Widget improvements
1141ad8
@jeffdaley
Tweak project options in modal
e7dafa8
@jeffdaley
Fix a couple Jira properties
d366a26
@jeffdaley
Fix formatting of POST
04ec5e2
@jeffdaley
Update add-to-or-create.hbs
cc88205
@jeffdaley
Merge branch 'main' into jeffdaley/projects-in-sidebar
0b644cb
@jeffdaley jeffdaley requested a review from a team as a code owner December 19, 2023 22:24
jfreda
jfreda approved these changes Dec 19, 2023
View reviewed changes
Copy link
Collaborator

@jfreda jfreda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

174 commits for a one line change, ha. But it's fine if we squash the PR when merging.

@jeffdaley jeffdaley merged commit 20adbf2 into main Dec 19, 2023
2 checks passed
@jeffdaley jeffdaley deleted the jeffdaley/projects-in-sidebar branch December 19, 2023 22:33
@jeffdaley
Copy link
Contributor Author

174 commits for a one line change, ha. But it's fine if we squash the PR when merging.

It was surprisingly grueling but I'm feeling good about it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jfreda jfreda jfreda approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jeffdaley @jfreda