Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: 🎸 initial LDAP authentication support #1645

Merged
merged 9 commits into from
May 11, 2023
Merged

feat: 🎸 initial LDAP authentication support #1645

merged 9 commits into from
May 11, 2023

Conversation

ghost
Copy link

@ghost ghost commented Feb 24, 2023 •
edited by DhariniJeeva

This pr lists LDAP on the signup/login form and allows authentication via LDAP on both admin and desktop UI

jira

admin ui:
Screenshot 2023-05-10 at 11 43 15 AM

Screenshot 2023-05-10 at 11 43 29 AM Screenshot 2023-05-10 at 11 43 42 AM

desktop:

Screenshot 2023-05-10 at 11 45 41 AM Screenshot 2023-05-10 at 11 55 14 AM Screenshot 2023-05-10 at 11 55 37 AM

feat: 🎸 initial LDAP authentication support
2e88c02 
does not include CRUD for LDAP yet
@vercel
Copy link

vercel bot commented Feb 24, 2023 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
boundary-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 11, 2023 7:46pm
boundary-ui-desktop ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 11, 2023 7:46pm
boundary-ui-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 11, 2023 7:46pm

@DhariniJeeva DhariniJeeva marked this pull request as ready for review May 10, 2023 22:16
@DhariniJeeva DhariniJeeva requested a review from a team as a code owner May 10, 2023 22:16
@DhariniJeeva DhariniJeeva self-assigned this May 10, 2023
lisbet-alvarez
lisbet-alvarez approved these changes May 11, 2023
View reviewed changes
Copy link
Collaborator

@lisbet-alvarez lisbet-alvarez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

cameronperera
cameronperera approved these changes May 11, 2023
View reviewed changes
Copy link
Collaborator

@cameronperera cameronperera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@DhariniJeeva DhariniJeeva merged commit 4c80f8d into main May 11, 2023
12 checks passed
@DhariniJeeva DhariniJeeva deleted the feature-ldap-authentication branch May 11, 2023 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dvonanderson dvonanderson Awaiting requested review from dvonanderson

Assignees

@DhariniJeeva DhariniJeeva

Labels
addons admin desktop ui
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@DhariniJeeva @cameronperera @lisbet-alvarez