chore: fix various build issues #211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiehan
requested review from
mutahhir and
DanielMSchmidt
and removed request for
a team
team-tf-cdk
approved these changes
Jul 11, 2023
team-tf-cdk
approved these changes
Jul 11, 2023
xiehan
added a commit
that referenced
this pull request
Jul 13, 2023
#211 finally fixed the `provider-upgrade` workflow that hadn't been working in months, but now a new problem appears: as you can see from #233, we're now getting PRs that wind up empty after the self-mutation step. In the short term, the best option is to add some steps to the build workflow to check whether all of the changes were undone after Projen's self-mutation, and to close the PR if so.
|
I'm going to lock this pull request because it has been closed for at least 30 days. This helps our maintainers find and focus on the active issues. If you've found a problem that seems related to this change, please open a new issue so we can investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a few build-related issues:
synchronizetrigger from the auto-approve workflow because it's obnoxious (re-approving the PR on every update)upgrade-mainworkflow because it's still not working -- hopefully adding thechowndoes the trickprovider-upgradeworkflow working which also hasn't run in months due to a missing token