Resolve hostnames in service-address command #260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Consul does not support hostnames for mesh gateway wan addresses. For now to support running on EKS we will resolve the EKS load balancer hostnames to IPs. In the future when Consul supports hostnames we will want to remove this change because the IPs may change and the hostname won't.
lkysow
force-pushed
the
service-address-resolve
branch
from
f59a584
to
f4344bc
Compare
|
Note: I've tested this in EKS and it solves the issue. |
ishustava
approved these changes
May 13, 2020
ndhanushkodi
pushed a commit
to ndhanushkodi/consul-k8s
that referenced
this pull request
Jul 9, 2021
Ensure caBundle is set to string
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consul does not support hostnames for mesh gateway wan addresses. For
now to support running on EKS we will resolve the EKS load balancer
hostnames to IPs.
In the future when Consul supports hostnames we will want to remove this
change because the IPs may change and the hostname won't.