Dont attempt to create '*' namespace #382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thisisnotashwin
requested review from
lkysow,
a team and
kschoche
and removed request for
a team
lkysow
approved these changes
Nov 6, 2020
Signed-off-by: Ashwin Venkatesh <ashwin@hashicorp.com> Signed-off-by: Luke Kysow <luke@hashicorp.com>
ndhanushkodi
pushed a commit
to ndhanushkodi/consul-k8s
that referenced
this pull request
Jul 9, 2021
Deprecate bootstrapACLs for acls.enabled
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this PR:
Interestingly, the consul API does not return
*namespace in a get request. This leads to us attempting to create the namespace when*is provided as a destination namespace for service intentions. This PR ensures we do not attempt to create the namespace when provided.How I've tested this PR:
How I expect reviewers to test this PR:
Checklist: