Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add descriptions and missing validation for service-intentions #385

Merged
merged 4 commits into from
Nov 9, 2020

Conversation

thisisnotashwin
Copy link
Contributor

@thisisnotashwin thisisnotashwin commented Nov 6, 2020

Changes proposed in this PR:

  • Add inline descriptions for the various fields of service-intentions
  • Add missing validations for service intentions

How I've tested this PR:

  • Unit tests

This was work that was previously skipped as we did not have enough documentation regarding service-intentions.

How I expect reviewers to test this PR:

  • Code Review

Checklist:

  • Tests added

api/v1alpha1/serviceintentions_types.go Show resolved Hide resolved
api/v1alpha1/serviceintentions_types.go Outdated Show resolved Hide resolved
api/v1alpha1/serviceintentions_types.go Outdated Show resolved Hide resolved
api/v1alpha1/serviceintentions_types.go Outdated Show resolved Hide resolved
api/v1alpha1/serviceintentions_types.go Outdated Show resolved Hide resolved
api/v1alpha1/serviceintentions_types.go Outdated Show resolved Hide resolved
api/v1alpha1/serviceintentions_types.go Show resolved Hide resolved
api/v1alpha1/serviceintentions_types.go Show resolved Hide resolved
Copy link
Contributor

@ishustava ishustava left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! I've left a couple of comments about, the main one being allowing hdrParts to be 0 as well as 1. Once that's fixed, it's good to go!

api/v1alpha1/serviceintentions_types.go Outdated Show resolved Hide resolved
api/v1alpha1/serviceintentions_types.go Show resolved Hide resolved
Co-authored-by: Iryna Shustava <ishustava@users.noreply.github.com>
@thisisnotashwin thisisnotashwin merged commit 548ae2e into master Nov 9, 2020
@thisisnotashwin thisisnotashwin deleted the intentions-validation branch November 9, 2020 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants