Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update tproxy logging messages to be a bit more informative #514

Merged
merged 3 commits into from
May 11, 2021

Conversation

kschoche
Copy link
Contributor

@kschoche kschoche commented May 6, 2021

Changes proposed in this PR:

  • connect-init will now periodically log a message stating that the pod is waiting on a Kubernetes service to be registered against and direct the user to logs in the webhook.
  • endpoints controller will now also log the serviceID and the remote agent's hostIP.

How I've tested this PR:
code review

How I expect reviewers to test this PR:
code review

Checklist:

  • Tests added
  • CHANGELOG entry added (HashiCorp engineers only, community PRs should not add a changelog entry)

@kschoche kschoche self-assigned this May 6, 2021
Copy link
Member

@lkysow lkysow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, just some small comments.

subcommand/connect-init/command.go Outdated Show resolved Hide resolved
subcommand/connect-init/command.go Outdated Show resolved Hide resolved
subcommand/connect-init/command.go Outdated Show resolved Hide resolved
subcommand/connect-init/command.go Outdated Show resolved Hide resolved
connect-inject/endpoints_controller.go Outdated Show resolved Hide resolved
@kschoche kschoche added the theme/tproxy Items related to transparent proxy label May 10, 2021
@kschoche kschoche marked this pull request as ready for review May 10, 2021 19:36
Copy link
Contributor

@thisisnotashwin thisisnotashwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks great!

@kschoche kschoche merged commit 6483e8c into master May 11, 2021
@kschoche kschoche deleted the tproxy_update_log_messages branch May 11, 2021 15:20
ndhanushkodi pushed a commit to ndhanushkodi/consul-k8s that referenced this pull request Jul 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
theme/tproxy Items related to transparent proxy
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants