Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't register duplicate services from different k8s namespaces #527

Merged
merged 4 commits into from
Jun 1, 2021

Conversation

ishustava
Copy link
Contributor

@ishustava ishustava commented Jun 1, 2021

When Consul namespaces are not enabled and we are processing a service
that already exists in Consul but with a different k8s namespace meta,
we skip service registration to avoid service name collisions.

How I've tested this PR:
unit-tests

How I expect reviewers to test this PR:
code review

Checklist:

  • Tests added
  • CHANGELOG entry added (HashiCorp engineers only, community PRs should not add a changelog entry)

@ishustava ishustava force-pushed the dont-register-duplicate-services branch 2 times, most recently from 43fae6f to a8a751a Compare June 1, 2021 15:04
When Consul namespaces are not enabled and we are processing a service
that already exists in Consul but with a different k8s namespace meta,
we skip service registration to avoid service name collisions.
@ishustava ishustava force-pushed the dont-register-duplicate-services branch from a8a751a to dadf217 Compare June 1, 2021 15:09
@ishustava ishustava requested review from a team, lkysow, thisisnotashwin and kschoche and removed request for a team and thisisnotashwin June 1, 2021 15:39
Copy link
Contributor

@kschoche kschoche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most excellent work!
I had a couple non-blocking questions/comments, but it looks great!

@ishustava ishustava requested review from ndhanushkodi and removed request for lkysow June 1, 2021 16:17
Copy link
Contributor

@ndhanushkodi ndhanushkodi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@ishustava ishustava merged commit 46cdc34 into master Jun 1, 2021
@ishustava ishustava deleted the dont-register-duplicate-services branch June 1, 2021 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants