Don't register duplicate services from different k8s namespaces #527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ishustava
force-pushed
the
dont-register-duplicate-services
branch
2 times, most recently
from
43fae6f
to
a8a751a
Compare
When Consul namespaces are not enabled and we are processing a service that already exists in Consul but with a different k8s namespace meta, we skip service registration to avoid service name collisions.
ishustava
force-pushed
the
dont-register-duplicate-services
branch
from
a8a751a
to
dadf217
Compare
ishustava
requested review from
a team,
lkysow,
thisisnotashwin and
kschoche
and removed request for
a team and
thisisnotashwin
kschoche
reviewed
Jun 1, 2021
kschoche
approved these changes
Jun 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When Consul namespaces are not enabled and we are processing a service
that already exists in Consul but with a different k8s namespace meta,
we skip service registration to avoid service name collisions.
How I've tested this PR:
unit-tests
How I expect reviewers to test this PR:
code review
Checklist: