Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

connect: redirect-traffic command should pass ACL token when ACL are enabled #576

Merged
merged 1 commit into from
Jul 30, 2021

Conversation

ishustava
Copy link
Contributor

Fixes #570,#568

Changes proposed in this PR:

  • redirect-traffic command should use an ACL token that we get from running consul login

How I've tested this PR:

How I expect reviewers to test this PR:

  • code review 👀

Checklist:

  • Tests added
  • CHANGELOG entry added (HashiCorp engineers only, community PRs should not add a changelog entry)

Copy link
Contributor

@kschoche kschoche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Good find 🥳

Copy link
Contributor

@sadjamz sadjamz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, good catch!

@ishustava ishustava merged commit 4a50fda into master Jul 30, 2021
@ishustava ishustava deleted the ishustava/fix-redirect-traffic-acl branch July 30, 2021 00:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consul's redirect-traffic command should run with the ACL token when ACLs are enabled
3 participants