Add config for webhook-cert-manager tolerations
#712
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-eckert
requested review from
a team,
lkysow and
ishustava
and removed request for
a team
lkysow
reviewed
Sep 2, 2021
kschoche
reviewed
Sep 7, 2021
Co-authored-by: Kyle Schochenmaier <kschoche@gmail.com>
t-eckert
requested review from
ndhanushkodi
and removed request for
ishustava
ndhanushkodi
approved these changes
Sep 9, 2021
There was a problem hiding this comment.
Looks great Thomas!!
I think the style of tolerations has varied throughout our values.yaml, with some being set to "" and some being set to null, but I think since the inconsistency exists already, and this matches one of the patterns, it still works. For example see https://github.com/hashicorp/consul-k8s/blob/main/charts/consul/values.yaml#L885-L895
|
@ndhanushkodi, I noticed that too. I thought it might be a good onboarding task to pick a standard and I can go through and change all of the nullish instances to use that in a later PR. |
lawliet89
pushed a commit
to lawliet89/consul-k8s
that referenced
this pull request
Sep 13, 2021
* Add a new flag to the framework, -use-kind. The only thing it affects currently are the mesh gateway tests: it uses NodePort service instead of the LoadBalancer service to expose the mesh gateways. This is because load balancer services are not available on kind. For the NodePort services, we don't need to do anything to allow cross-cluster communication because kind uses the docker bridge network, and so the nodes are reachable by default. * Change the main pipeline to use kind instead of gke, and move gke tests to the nightly pipeline. * Use circleci's parallelism feature to run tests in parallel. Currently, tests are split by package, which is not the best efficient way to parallelize them, but we can address that at a later time. Currently, using 6 parallel nodes reduces the test runtime to about 30min.
t-eckert
pushed a commit
that referenced
this pull request
Sep 17, 2021
* Add webhookCertManager.tolerations setting * Add tolerations to webhook cert template * Add bats test for setting tolerations * Update CHANGELOG * Set PR number in CHANGELOG * Add short desc to webhookCertManager * Update charts/consul/values.yaml Co-authored-by: Kyle Schochenmaier <kschoche@gmail.com> Co-authored-by: Kyle Schochenmaier <kschoche@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this PR:
This work closes issue #655 where the user was running Consul on a private cluster in GKE.
How I've tested this PR:
Added bats and manually produced the deployment YAML using helm.
How I expect reviewers to test this PR:
Run bats
Checklist: