Add support for PartitionExports #802
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- This PR does not include acceptance tests. The desired acceptance tests will be determined based on the expected behavior of ServiceExports when partitions are disabled. - Similarly, controller tests have not been added as our existing controller tests only account for namespace. The behavior with partitions has not been resolved.
thisisnotashwin
requested review from
ndhanushkodi,
a team and
ishustava
and removed request for
a team
thisisnotashwin
force-pushed
the
service-exports
branch
from
01fc9f6
to
e2e4385
Compare
|
Just in case it wasn't already on your radar -- Could you also just change the PR title/commit message when merging? |
thisisnotashwin
changed the title
ottaviohartman
pushed a commit
to ottaviohartman/consul-k8s
that referenced
this pull request
Nov 3, 2021
* Create templates for grafana and prometheus
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this PR:
How I've tested this PR:
How I expect reviewers to test this PR:
The behavior of ServiceExports can be tested once changes are made to the mesh gateway to support Cross Partitions communication.
A follow-up PR will contain a refactor to the ConfigEntry interface which should simplify testing validation behavior when partitions are enabled/disabled.
Once the behavior of Consul OSS has been determined wrt to ServiceExports, Acceptance tests and controller tests will be updated with the tests to comprehensively test the ServiceExport CRD.
Checklist: